From: Jonathan Cameron <jic23@kernel.org>
To: Tolga Ceylan <tolga.ceylan@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging: iio: meter: ade7854-i2c: code style improvements
Date: Sun, 08 Mar 2015 12:02:54 +0000 [thread overview]
Message-ID: <54FC3A6E.1050609@kernel.org> (raw)
In-Reply-To: <1423974765-1782-3-git-send-email-tolga.ceylan@gmail.com>
On 15/02/15 04:32, Tolga Ceylan wrote:
> Code reformatting based on checkpatch.pl with --strict:
> Comparison to NULL rewritten as !indio_dev
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
Whilst I find it hard to care on this particular fix.. what the heck.
Applied to the togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/staging/iio/meter/ade7854-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index 5e6fbe4..4e7a382 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -210,7 +210,7 @@ static int ade7854_i2c_probe(struct i2c_client *client,
> struct iio_dev *indio_dev;
>
> indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*st));
> - if (indio_dev == NULL)
> + if (!indio_dev)
> return -ENOMEM;
> st = iio_priv(indio_dev);
> i2c_set_clientdata(client, indio_dev);
>
next prev parent reply other threads:[~2015-03-08 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 4:32 [PATCH 1/3] Staging: iio: meter: ade7854-i2c: code style improvements Tolga Ceylan
2015-02-15 4:32 ` [PATCH 2/3] " Tolga Ceylan
2015-03-08 12:01 ` Jonathan Cameron
2015-02-15 4:32 ` [PATCH 3/3] " Tolga Ceylan
2015-03-08 12:02 ` Jonathan Cameron [this message]
2015-03-08 11:59 ` [PATCH 1/3] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FC3A6E.1050609@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tolga.ceylan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.