All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Yegor Yefremov <yegorslists@googlemail.com>, linux-can@vger.kernel.org
Subject: Re: [PATCH] autotools: define N_SLCAN, if not already declared
Date: Sun, 08 Mar 2015 15:57:56 +0100	[thread overview]
Message-ID: <54FC6374.2060002@hartkopp.net> (raw)
In-Reply-To: <1425823253-27821-1-git-send-email-yegorslists@googlemail.com>

Good idea!

Actually a colleague recently had the problem that N_SLCAN was not defined on 
some older Redhat 6.x machine with 2.6.32 Kernel and 'even older' includes.

The patch from Jeremiah which was removing this private define

https://github.com/linux-can/can-utils/commit/ca7990919717b8e2c841552139ad221e58e8bb69

created the compile issue. So your patch fixes this problem in the correct way :-)

Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>

Thanks,
Oliver

On 08.03.2015 15:00, Yegor Yefremov wrote:
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>   configure.ac | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 3b695d3..633ba81 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -83,6 +83,9 @@ AC_CHECK_DECL(PF_CAN,,
>   AC_CHECK_DECL(AF_CAN,,
>       [AC_DEFINE([AF_CAN], [PF_CAN], [AF_CAN])]
>   )
> +AC_CHECK_DECL(N_SLCAN,,
> +    [AC_DEFINE([N_SLCAN], [17], [N_SLCAN])]
> +)
>
>
>   #
>

      reply	other threads:[~2015-03-08 14:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-08 14:00 [PATCH] autotools: define N_SLCAN, if not already declared Yegor Yefremov
2015-03-08 14:57 ` Oliver Hartkopp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FC6374.2060002@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can@vger.kernel.org \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.