From: Jeff Kirsher <tarbal@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] vlan: allow changing VLAN id and protocol
Date: Sun, 08 Mar 2015 11:25:42 -0700 [thread overview]
Message-ID: <54FC9426.7040708@gmail.com> (raw)
In-Reply-To: <20150308110624.5ab6f662@urahara>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 03/08/2015 11:06 AM, Stephen Hemminger wrote:
>
> The VLAN netlink interface allows changing the ID and protocol of an existing
> VLAN, but it was being ignored. Move the initialization of the proto and
> id into the change function to fix that.
>
> Example of the problem:
> # modprobe dummy
> # ip li set dev dummy0 up
> # ip li add link dummy0 name dummy0.10 type vlan id 100
> # ip li set dummy0.10 type vlan id 111
> # ip -d li show dev dummy0.10
> 19: dummy0.10@dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT
> link/ether be:d3:7c:7f:86:18 brd ff:ff:ff:ff:ff:ff
> vlan id 100 <REORDER_HDR>
> ^^^ should be 111
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCgAGBQJU/JQlAAoJEOVv75VaS+3OnY8P/2JXfEavZqtBzK2wSRxaJ5o0
PU8FVutYDQ/DFFixEFtIaMY+nVpuViRXmUfowUEbXI5VOeoqwxhC5ek1V4c1TeAl
1gac0oY0ynqFHuAkj2MCkTR32IuOoLEjphekeYbJsLoMY4lF6iCXlQiJ+fboethk
u10p10l4nE16gKCohLvrfW9TjXKF0SiRN70tqOWwwyrhL8YYL4ifE3AQbt3cStvw
wzKrraMueodhtG1SJqVPnr2Iui7LN1hwQFH+J6V0RPYc6hqenQewgP+s4TaWd/a0
9iur1uJXnXvHGihh7HHIuF8ARQhSwlNRMXIq1T87F/qZIpHuUOouMDBZrrgSyBjJ
QAM9gSL5Yd9HX91W1wxl00dvc00GdZFd+x9Zb7ROV42biiA1Yudua3TjzqEbwc61
JM5kR7GUiThqPcWmC+9YjYCbE1ciidepD3LxtjKBQdVIdDUiim0jLzUv1d45L3ne
hsGuB6F64M0iTEHxM8c8NhwYiOpnl6lqaKAHAyGhBKLLlGkAyuktIr8+eXImxTz8
xu7q/DdX/z9/l8rNiqZmM9dI7cOrsW3BgvMi+/bpcbwe8vwIdir/GUpQ0duapG8z
OiNt5Xqda18FsFUyLRe1iq1YbeRLpRt0c+guMMTqLaa1m4i2LwiEEnKF8Ofklk6q
vA4U4evsyN4ROSUjJbAe
=yuzw
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-03-08 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 18:06 [PATCH net-next] vlan: allow changing VLAN id and protocol Stephen Hemminger
2015-03-08 18:25 ` Jeff Kirsher [this message]
2015-03-08 21:44 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FC9426.7040708@gmail.com \
--to=tarbal@gmail.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.