From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUmTL-0003xR-3L for qemu-devel@nongnu.org; Sun, 08 Mar 2015 21:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUmTH-0000xz-TF for qemu-devel@nongnu.org; Sun, 08 Mar 2015 21:27:07 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:56686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUmTH-0000xl-7v for qemu-devel@nongnu.org; Sun, 08 Mar 2015 21:27:03 -0400 Message-ID: <54FCF6D7.5080500@huawei.com> Date: Mon, 9 Mar 2015 09:26:47 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1425478176-12044-1-git-send-email-zhang.zhanghailiang@huawei.com> <1425478176-12044-2-git-send-email-zhang.zhanghailiang@huawei.com> <54F9D25B.60101@redhat.com> In-Reply-To: <54F9D25B.60101@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/4] migration: Rename abbreviated macro MIG_STATE_* to MIGRATION_STATUS_* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: hangaohuai@huawei.com, quintela@redhat.com, armbru@redhat.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, amit.shah@redhat.com, lcapitulino@redhat.com On 2015/3/7 0:14, Eric Blake wrote: > On 03/04/2015 07:09 AM, zhanghailiang wrote: >> Signed-off-by: zhanghailiang >> --- >> migration/migration.c | 93 +++++++++++++++++++++++++++------------------------ >> 1 file changed, 50 insertions(+), 43 deletions(-) >> >> diff --git a/migration/migration.c b/migration/migration.c >> index b3adbc6..0aafbdf 100644 >> --- a/migration/migration.c >> +++ b/migration/migration.c >> @@ -27,13 +27,13 @@ >> #include "trace.h" >> >> enum { >> - MIG_STATE_ERROR = -1, >> - MIG_STATE_NONE, >> - MIG_STATE_SETUP, >> - MIG_STATE_CANCELLING, >> - MIG_STATE_CANCELLED, >> - MIG_STATE_ACTIVE, >> - MIG_STATE_COMPLETED, >> + MIGRATION_STATUS_ERROR = -1, > > Please also rename _ERROR to _FAILED in this patch, so that patch 3/4 is > not doing any further renames. And document that the rename is > intentional in the body of the commit message. > OK, will fix in v4~ > >> @@ -251,11 +251,11 @@ MigrationInfo *qmp_query_migrate(Error **errp) >> info->ram->mbps = s->mbps; >> info->ram->dirty_sync_count = s->dirty_sync_count; >> break; >> - case MIG_STATE_ERROR: >> + case MIGRATION_STATUS_ERROR: >> info->has_status = true; >> info->status = g_strdup("failed"); >> break; > > That is, _this_ patch is the one to make the enum name match the public > string. >