From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUmUF-0004sD-Mj for qemu-devel@nongnu.org; Sun, 08 Mar 2015 21:28:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUmUA-00017E-NQ for qemu-devel@nongnu.org; Sun, 08 Mar 2015 21:28:03 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:3967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUmUA-00016t-0M for qemu-devel@nongnu.org; Sun, 08 Mar 2015 21:27:58 -0400 Message-ID: <54FCF70E.1000103@huawei.com> Date: Mon, 9 Mar 2015 09:27:42 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1425478176-12044-1-git-send-email-zhang.zhanghailiang@huawei.com> <1425478176-12044-5-git-send-email-zhang.zhanghailiang@huawei.com> <54F9D4C0.8010705@redhat.com> In-Reply-To: <54F9D4C0.8010705@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 4/4] migration: Expose 'cancelling' status to user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: hangaohuai@huawei.com, quintela@redhat.com, libvir-list@redhat.com, armbru@redhat.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, amit.shah@redhat.com, lcapitulino@redhat.com On 2015/3/7 0:24, Eric Blake wrote: > On 03/04/2015 07:09 AM, zhanghailiang wrote: >> 'cancelling' status is introduced by commit 51cf4c1a, which is mainly avoid > > s/is introduced/was introduced/ > s/which is mainly avoid/mainly to avoid a/ > >> possible starting a new migration process while the previous one still exist. > > s/starting a new/start of a new/ > s/exist/exists/ > >> But we don't expose this status to user, instead by return a 'active' state. > > s/don't/didn't/ > s/by return a/we returned the/ > >> >> Here, we expose it to the user (such as libvirt), 'cancelling' status only >> occurs for a short window before the migration aborts, so for users, >> if they cancell a migration process, it will observe 'cancelling' status > > s/cancell/cancel/ > >> occasionally. > > Add: > Testing revealed that with older libvirt (anything 1.2.13 or less) will > print an odd error message if the state is seen, but that the migration > is still properly cancelled. Newer libvirt will be patched to recognize > the new state without the odd error message. > >> >> Signed-off-by: zhanghailiang >> Cc: libvir-list@redhat.com >> --- >> migration/migration.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) > > With the grammar in the commit message fixed, > Reviewed-by: Eric Blake > OK, will fix that in v4, thanks.