From mboxrd@z Thu Jan  1 00:00:00 1970
From: yakir <ykk@rock-chips.com>
Subject: Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style
Date: Mon, 09 Mar 2015 15:25:30 +0800
Message-ID: <54FD4AEA.6000507@rock-chips.com>
References: <425876114-22392-1-git-send-email-ykk@rock-chips.com> <1425876147-22456-1-git-send-email-ykk@rock-chips.com> <CAGS+omAji7xMfeTN9N1Oh28TgKCG3BzCgDra2GGzzmfNiygoZg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAGS+omAji7xMfeTN9N1Oh28TgKCG3BzCgDra2GGzzmfNiygoZg@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: David Airlie <airlied@linux.ie>, Russell King <rmk+kernel@arm.linux.org.uk>, Philipp Zabel <p.zabel@pengutronix.de>, Fabio Estevam <fabio.estevam@freescale.com>, =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= <mmind00@googlemail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Douglas Anderson <dianders@chromium.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, Rob Clark <robdclark@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, =?UTF-8?B?U3TDqXBoYW5lIE1hcmNoZXNpbg==?= <marcheu@chromium.org>, Andy Yan <andy.yan@rock-chips.com>, Shawn Guo <shawn.guo@linaro.org>, Mark Yao <mark.yao@rock-chips.com>
List-Id: dri-devel@lists.freedesktop.org


On 2015=E5=B9=B403=E6=9C=8809=E6=97=A5 15:05, Daniel Kurtz wrote:
> On Mon, Mar 9, 2015 at 12:42 PM, Yakir Yang <ykk@rock-chips.com> wrot=
e:
>> - const struct dw_hdmi_mpll_config *mpll_config =3D
>> -                                        hdmi->plat_data->mpll_cfg;
>> - const struct dw_hdmi_curr_ctrl *curr_ctrl =3D hdmi->plat_data->cur=
_ctr;
>> - const struct dw_hdmi_sym_term *sym_term =3D  hdmi->plat_data->sym_=
term;
>>
>> + const struct dw_hdmi_plat_data *plat_data =3D hdmi->plat_data;
>> + const struct dw_hdmi_mpll_config *mpll_config =3D plat_data->mpll_=
cfg;
>> + const struct dw_hdmi_curr_ctrl *curr_ctrl =3D plat_data->cur_ctr;
>> + const struct dw_hdmi_sym_term *sym_term =3D  plat_data->sym_term;
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> I agree with Joe Perches that this commit message is not very clear.
> It should summarize what the patches is doing and why, not just be a
> copy of the change.
> e.g., "Using a local struct pointer to reduce one level of indirectio=
n
> makes the code slightly more readable."
>
> , but otherwise this is:
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

Okay, I will correct it now.

Thanks for your reivew  :)

>> ---
>>
>> Changes in v2: None
>>
>>   drivers/gpu/drm/bridge/dw_hdmi.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/brid=
ge/dw_hdmi.c
>> index 9ffc257..b9d8d8a 100644
>> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
>> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
>> @@ -900,10 +900,10 @@ static int hdmi_phy_configure(struct dw_hdmi *=
hdmi, unsigned char prep,
>>   {
>>          unsigned res_idx, i;
>>          u8 val, msec;
>> -       const struct dw_hdmi_mpll_config *mpll_config =3D
>> -                                               hdmi->plat_data->mpl=
l_cfg;
>> -       const struct dw_hdmi_curr_ctrl *curr_ctrl =3D hdmi->plat_dat=
a->cur_ctr;
>> -       const struct dw_hdmi_sym_term *sym_term =3D  hdmi->plat_data=
->sym_term;
>> +       const struct dw_hdmi_plat_data *plat_data =3D hdmi->plat_dat=
a;
>> +       const struct dw_hdmi_mpll_config *mpll_config =3D plat_data-=
>mpll_cfg;
>> +       const struct dw_hdmi_curr_ctrl *curr_ctrl =3D plat_data->cur=
_ctr;
>> +       const struct dw_hdmi_sym_term *sym_term =3D  plat_data->sym_=
term;
>>
>>          if (prep)
>>                  return -EINVAL;
>> --
>> 2.1.2
>>
>>
>>
>> _______________________________________________
>> Linux-rockchip mailing list
>> Linux-rockchip@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
>