All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ondrej Kozina <okozina@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] fsadm: add support for btrfs
Date: Mon, 09 Mar 2015 09:31:43 +0100	[thread overview]
Message-ID: <54FD5A6F.90806@redhat.com> (raw)
In-Reply-To: <1425883705-8022-1-git-send-email-lzhong@suse.com>

On 03/09/2015 07:48 AM, Lidong Zhong wrote:
> Run `btrfs check` to check filesystem
> Run `btrfs filesystem show` to get the filesystem size and
> `btrfs filesystem resize` to resize.
>

Hi,

thank you for the patch but I'm afraid it is not correct. For example it 
doesn't seem to deal with the possibility of btrfs volume spanning 
across multiple block devices. You have to resize (meant with btrfs 
tools) specific subvolume to not to break the filesystem on LV about to 
get resized with lvresize.

I proposed similar patch before 
(http://www.redhat.com/archives/lvm-devel/2012-November/msg00052.html) 
but in the end came to conclusion it was not worth the pain considering 
the btrfs-check couldn't detect even elemental fs breakage. Is the state 
of btrfs-check tool better than what I described earlier in my patch header?

Kind regards
Ondrej

PS: The original patch is from 2012 so perhaps some of the magic I used 
to extract proper btrfs device id is useless as of now. At least I hope 
so...



  reply	other threads:[~2015-03-09  8:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09  6:48 [PATCH] fsadm: add support for btrfs Lidong Zhong
2015-03-09  8:31 ` Ondrej Kozina [this message]
2015-03-10  8:13   ` Lidong Zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FD5A6F.90806@redhat.com \
    --to=okozina@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.