From: Julien Grall <julien.grall@linaro.org>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com
Subject: Re: [PATCH v2 1/2] xen/arm: Add Cadence UART driver
Date: Mon, 09 Mar 2015 12:47:51 +0200 [thread overview]
Message-ID: <54FD7A57.7090601@linaro.org> (raw)
In-Reply-To: <1425604081-29730-2-git-send-email-edgar.iglesias@gmail.com>
Hi Edgar,
On 06/03/2015 03:08, Edgar E. Iglesias wrote:
> +#define cuart_read(uart, off) readl((uart)->regs + (off))
> +#define cuart_write(uart, off,val) writel((val), (uart)->regs + (off))
> +
> +static void cuart_interrupt(int irq, void *data, struct cpu_user_regs *regs)
> +{
> + struct serial_port *port = data;
> + struct cuart *uart = port->uart;
> + unsigned int status;
> +
> + do {
> + status = cuart_read(uart, R_UART_SR);
> + /* ACK. */
> + if (status & UART_SR_INTR_RTRIG) {
[..]
> +static void __init cuart_init_postirq(struct serial_port *port)
> +{
> + struct cuart *uart = port->uart;
> + int rc;
> +
> + if ( uart->irq > 0 ) {
Can you be consistent with the coding style? Either use Linux or Xen one
but not a mix of them.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-03-09 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 1:07 [PATCH v2 0/2] Add support for Xilinx ZynqMP SoC Edgar E. Iglesias
2015-03-06 1:08 ` [PATCH v2 1/2] xen/arm: Add Cadence UART driver Edgar E. Iglesias
2015-03-09 10:47 ` Julien Grall [this message]
2015-03-09 11:59 ` Edgar E. Iglesias
2015-03-06 1:08 ` [PATCH v2 2/2] xen/arm: Add Xilinx ZynqMP early printk support Edgar E. Iglesias
2015-03-09 11:51 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FD7A57.7090601@linaro.org \
--to=julien.grall@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.