From: Lars-Peter Clausen <lars@metafoo.de>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
broonie@kernel.org, lgirdwood@gmail.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH_V2] ASoC: jz4740: Add jz4780 support
Date: Mon, 09 Mar 2015 12:54:50 +0100 [thread overview]
Message-ID: <54FD8A0A.4080909@metafoo.de> (raw)
In-Reply-To: <1425900224-52026-1-git-send-email-Zubair.Kakakhel@imgtec.com>
On 03/09/2015 12:23 PM, Zubair Lutfullah Kakakhel wrote:
[...]
> @@ -460,6 +499,9 @@ static int jz4740_i2s_dev_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, i2s);
>
> + if (i2s->version >= JZ_I2S_JZ4780)
> + jz4740_i2s_dai.symmetric_rates = 0;
We shouldn't modify driver global structs from a device instance. Just add a
second copy of jz4740_i2s_dai for the jz4780 without the bit set.
- Lars
prev parent reply other threads:[~2015-03-09 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 11:23 [PATCH_V2] ASoC: jz4740: Add jz4780 support Zubair Lutfullah Kakakhel
2015-03-09 11:23 ` Zubair Lutfullah Kakakhel
2015-03-09 11:54 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FD8A0A.4080909@metafoo.de \
--to=lars@metafoo.de \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.