From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Bandan Das <bsd@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: make halt_poll_ns static
Date: Mon, 09 Mar 2015 13:15:59 +0100 [thread overview]
Message-ID: <54FD8EFF.1030902@de.ibm.com> (raw)
In-Reply-To: <54F62BA8.4000401@de.ibm.com>
Am 03.03.2015 um 22:46 schrieb Christian Borntraeger:
[...]
>
> halt_poll_ns is used only locally. Make it static and remove
> the initializer.
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 34310a8..58bc2a9 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -66,7 +66,7 @@
> MODULE_AUTHOR("Qumranet");
> MODULE_LICENSE("GPL");
>
> -unsigned int halt_poll_ns = 0;
> +static unsigned int halt_poll_ns;
> module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
>
> /*
>
>
> Otherwise I will resend.
Ping. Do you want me to send that via my next pull request for s390 or shall I
resend as a standalone patch for you to apply?
Christian
next prev parent reply other threads:[~2015-03-09 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 15:50 [PATCH] KVM: make halt_poll_ns static Christian Borntraeger
2015-03-03 21:42 ` Bandan Das
2015-03-03 21:46 ` Christian Borntraeger
2015-03-09 12:15 ` Christian Borntraeger [this message]
2015-03-09 21:38 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FD8EFF.1030902@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.