Re: [PATCH V3 0/9] iio: mma8452 enhancements

[Jonathan Cameron <jic23@kernel.org>]

On 25/02/15 23:11, Peter Meerwald wrote:
> 
>> This series adds some additional features to the mma8452 accelerometer driver
>> 	* debugfs register access
>> 	* transient threshold events
>> 	* highpass filter
>> 	* interrupt driven sampling (trigger)
>> 	* self test mode
> 
> looks good except some very minor things;
> great to see the code is used and enhanced
I'm happy with all the patches I didn't comment on.

Looks good Martin, not much to tidy up!
>  
>> Attributes are added to the core for:
>> * highpass filter for readings
>> * both high and lowpass filters for events
>>
>> In addition a latent bug in the device initialisation is fixed.
>>
>> V3 changes:
>> 	Use 3db frequency for filter enable / disable (0=disable)
>> 	Support enabling filter for readings in addition to events
>> 	Use IIO_EV_INFO_PERIOD rather than custom attribute
>> 	Use devm_iio_trigger_alloc()
>> 	Add comment to explain irq activation during probe()
>> 	iio_device_register() only after all setup
>> 	Drop iio_push_event() wrapper
>> 	Correct parameters to iio_push_event()
>> 	Document missing attributes
>> 	Add self test mode
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>