From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH] kbuild: Don't pass -rR to selftest makefiles Date: Mon, 09 Mar 2015 08:28:56 -0600 Message-ID: <54FDAE28.6050801@osg.samsung.com> References: <1425464362-28876-1-git-send-email-mpe@ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1425464362-28876-1-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michael Ellerman , mmarek-AlSwsSmVLrQ@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davej-rdkfGonbjUTCLXcRTR1eJlpr/1R2p/CL@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On 03/04/2015 03:19 AM, Michael Ellerman wrote: > The makefiles under tools/testing/selftests are not real kbuild > makefiles, they are regular stand alone makefiles. As such they *do* > want all the standard implicit rules and variables defined. > > So before calling those makefiles, filter -rR out of MAKEFLAGS. > > Without this not all the selftests are built correctly when called via > the top-level Makefile. > > Signed-off-by: Michael Ellerman Hi Michal, Could you please take this patch in your tree. Acked-by: Shuah Khan thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932101AbbCIO3C (ORCPT ); Mon, 9 Mar 2015 10:29:02 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54529 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753778AbbCIO25 (ORCPT ); Mon, 9 Mar 2015 10:28:57 -0400 Message-ID: <54FDAE28.6050801@osg.samsung.com> Date: Mon, 09 Mar 2015 08:28:56 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman , mmarek@suse.cz CC: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk, linux-api@vger.kernel.org Subject: Re: [PATCH] kbuild: Don't pass -rR to selftest makefiles References: <1425464362-28876-1-git-send-email-mpe@ellerman.id.au> In-Reply-To: <1425464362-28876-1-git-send-email-mpe@ellerman.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2015 03:19 AM, Michael Ellerman wrote: > The makefiles under tools/testing/selftests are not real kbuild > makefiles, they are regular stand alone makefiles. As such they *do* > want all the standard implicit rules and variables defined. > > So before calling those makefiles, filter -rR out of MAKEFLAGS. > > Without this not all the selftests are built correctly when called via > the top-level Makefile. > > Signed-off-by: Michael Ellerman Hi Michal, Could you please take this patch in your tree. Acked-by: Shuah Khan thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978