From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932101AbbCIQS7 (ORCPT ); Mon, 9 Mar 2015 12:18:59 -0400 Received: from mail-we0-f171.google.com ([74.125.82.171]:34987 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754760AbbCIQSz (ORCPT ); Mon, 9 Mar 2015 12:18:55 -0400 Message-ID: <54FDC7E0.9080502@gmail.com> Date: Mon, 09 Mar 2015 18:18:40 +0200 From: =?UTF-8?B?R2llZHJpdXMgU3RhdGtldmnEjWl1cw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: lidza.louina@gmail.com, markh@compro.net CC: gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH] dgnc: Don't save boards in memory that have failed to initialize References: <1425914824-17488-1-git-send-email-giedrius.statkevicius@gmail.com> In-Reply-To: <1425914824-17488-1-git-send-email-giedrius.statkevicius@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015.03.09 17:27, Giedrius Statkevičius wrote: > Remove BOARD_FAILED and don't save dgnc_boards which failed to > initialize. > > Assign the result of kzalloc() to brd in dgnc_found_board() and only put > it in the dgnc_Board[] if it successfully initializes. Also, remove > BOARD_FAILED enum and all ifs that check for it. Finally, remove one > final place where state was set to BOARD_FAILED which was even redundant > before this patch. > > Signed-off-by: Giedrius Statkevičius > --- > drivers/staging/dgnc/dgnc_driver.c | 19 ++----------------- > drivers/staging/dgnc/dgnc_driver.h | 3 +-- > drivers/staging/dgnc/dgnc_mgmt.c | 5 +---- > drivers/staging/dgnc/dgnc_tty.c | 8 -------- > 4 files changed, 4 insertions(+), 31 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c > index fa1ee79..c73dc1f 100644 > --- a/drivers/staging/dgnc/dgnc_driver.c > +++ b/drivers/staging/dgnc/dgnc_driver.c > @@ -401,7 +401,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id) > unsigned long flags; > > /* get the board structure and prep it */ > - dgnc_Board[dgnc_NumBoards] = kzalloc(sizeof(*brd), GFP_KERNEL); > + brd = kzalloc(sizeof(*brd), GFP_KERNEL); > brd = dgnc_Board[dgnc_NumBoards]; err, forgot to remove this here. Posting v2.