Re: [RFC PATCH 00/19] xen/arm: Add ITS support

[Julien Grall <julien.grall@linaro.org>]

Hello Vijay,

On 09/03/2015 14:57, Vijay Kilari wrote:
> On Tue, Mar 3, 2015 at 5:13 PM, Julien Grall <julien.grall@linaro.org> wrote:
>> Hello Vijay,
>>
>> On 03/03/2015 03:55, Vijay Kilari wrote:
>>>
>>> On Mon, Mar 2, 2015 at 6:49 PM, Julien Grall <julien.grall@linaro.org>
>>> wrote:
>>>>
>>>> On 02/03/15 12:30, vijay.kilari@gmail.com wrote:
>>>>>
>>>>> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>>>>>
>>>>> Add ITS support for arm. Following major features
>>>>> are supported
>>>>>    - GICv3 ITS support for arm64 platform
>>>>>    - Supports only single ITS node
>>>>
>>>>
>>>> Why only one ITS node supported? I though Cavium was using 2 ITS...
>>>
>>>
>>> I will update for 2 ITS nodes later when NUMA is supported
>>
>>
>> Why do you speak about NUMA? AFAICT, there is no requirement to support NUMA
>> for having multiple ITS...
>>
>> With multiple ITS support, your vITS emulation will likely heavily change.
>> So it would be nice to have this support as soon as possible.
>
> Incremental changes (as separate patch series)
> would be more meaningful. I will have a look at it
> and if possible I will incorporate in next series

It doesn't make sense to not support multiple ITS from the beginning.

FWIW, your code is based on the Linux driver which support multiple ITS. 
So why did you drop this support?

Anyway, I'm pretty sure you will have to rework the vITS with the 
support of multiple ITS... Having a separate patch means more work for 
all of us: more series and more review.

>> What is missing to support guest? Only the toolstack part?
>
> Yes, it is only toolstack part similar to GICv3

Ok.

>> BTW, do you have a tree with all the code?
>
> Yes, I have a tree, But I cannot share it. Github is ok?

Sure.


Regards,

-- 
Julien Grall