From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH] kbuild: Don't pass -rR to selftest makefiles Date: Mon, 09 Mar 2015 16:49:27 -0600 Message-ID: <54FE2377.9040709@osg.samsung.com> References: <1425464362-28876-1-git-send-email-mpe@ellerman.id.au> <54FDAE28.6050801@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <54FDAE28.6050801-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michael Ellerman , mmarek-AlSwsSmVLrQ@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davej-rdkfGonbjUTCLXcRTR1eJlpr/1R2p/CL@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On 03/09/2015 08:28 AM, Shuah Khan wrote: > On 03/04/2015 03:19 AM, Michael Ellerman wrote: >> The makefiles under tools/testing/selftests are not real kbuild >> makefiles, they are regular stand alone makefiles. As such they *do* >> want all the standard implicit rules and variables defined. >> >> So before calling those makefiles, filter -rR out of MAKEFLAGS. >> >> Without this not all the selftests are built correctly when called v= ia >> the top-level Makefile. >> >> Signed-off-by: Michael Ellerman >=20 > Hi Michal, >=20 > Could you please take this patch in your tree. >=20 > Acked-by: Shuah Khan >=20 I am changing this to a Nack. This is not fully cooked. I am seeing new failures on some tests. gcc: error: elf_x86_64: No such file or directory gcc: error: unrecognized command line option =91-m=92 thanks, -- Shuah --=20 Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932070AbbCIWtc (ORCPT ); Mon, 9 Mar 2015 18:49:32 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54589 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbbCIWt3 (ORCPT ); Mon, 9 Mar 2015 18:49:29 -0400 Message-ID: <54FE2377.9040709@osg.samsung.com> Date: Mon, 09 Mar 2015 16:49:27 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman , mmarek@suse.cz CC: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk, linux-api@vger.kernel.org Subject: Re: [PATCH] kbuild: Don't pass -rR to selftest makefiles References: <1425464362-28876-1-git-send-email-mpe@ellerman.id.au> <54FDAE28.6050801@osg.samsung.com> In-Reply-To: <54FDAE28.6050801@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2015 08:28 AM, Shuah Khan wrote: > On 03/04/2015 03:19 AM, Michael Ellerman wrote: >> The makefiles under tools/testing/selftests are not real kbuild >> makefiles, they are regular stand alone makefiles. As such they *do* >> want all the standard implicit rules and variables defined. >> >> So before calling those makefiles, filter -rR out of MAKEFLAGS. >> >> Without this not all the selftests are built correctly when called via >> the top-level Makefile. >> >> Signed-off-by: Michael Ellerman > > Hi Michal, > > Could you please take this patch in your tree. > > Acked-by: Shuah Khan > I am changing this to a Nack. This is not fully cooked. I am seeing new failures on some tests. gcc: error: elf_x86_64: No such file or directory gcc: error: unrecognized command line option ‘-m’ thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978