From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60519)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YV82E-0000yM-Bf
	for qemu-devel@nongnu.org; Mon, 09 Mar 2015 20:28:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YV82B-0007lK-4M
	for qemu-devel@nongnu.org; Mon, 09 Mar 2015 20:28:34 -0400
Received: from mga11.intel.com ([192.55.52.93]:35780)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YV82A-0007lG-VF
	for qemu-devel@nongnu.org; Mon, 09 Mar 2015 20:28:31 -0400
Message-ID: <54FE3AAC.7040301@intel.com>
Date: Tue, 10 Mar 2015 08:28:28 +0800
From: "Chen, Tiejun" <tiejun.chen@intel.com>
MIME-Version: 1.0
References: <1425632903-5502-1-git-send-email-tiejun.chen@intel.com>
	<1425632903-5502-3-git-send-email-tiejun.chen@intel.com>
	<20150306125545.GP12103@zion.uk.xensource.com>
	<54FD4190.80606@intel.com>
	<20150309101734.GC18491@zion.uk.xensource.com>
In-Reply-To: <20150309101734.GC18491@zion.uk.xensource.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wei Liu <wei.liu2@citrix.com>
Cc: qemu-devel@nongnu.org, stefano.stabellini@citrix.com, Ian.Jackson@eu.citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org

On 2015/3/9 18:17, Wei Liu wrote:
> On Mon, Mar 09, 2015 at 02:45:36PM +0800, Chen, Tiejun wrote:
> [...]
>>>
>>>> +                exit (1);
>>>> +            }
>>>> +        } else if (!xlu_cfg_get_string(config, "gfx_passthru", &buf, 0)) {
>>>> +            if (libxl_gfx_passthru_kind_from_string(buf, &b_info->u.hvm.gfx_passthru_kind)) {
>>>
>>> Ditto.
>>>
>>>> +                fprintf(stderr, "ERROR: invalid value \"%s\" for \"gfx_passthru\"\n",
>>>
>>> Ditto.
>>
>> So,
>>
>> @@ -1959,13 +1959,15 @@ skip_vfb:
>>               } else if (i == 1) {
>>                   libxl_defbool_set(&b_info->u.hvm.gfx_passthru, true);
>>               } else {
>> -                fprintf(stderr, "ERROR: invalid value %ld for
>> \"gfx_passthru\"\n", l);
>> +                fprintf(stderr, "ERROR: invalid value %ld for"
>> +                                " \"gfx_passthru\"\n", l);
>>                   exit (1);
>>               }
>>           } else if (!xlu_cfg_get_string(config, "gfx_passthru", &buf, 0)) {
>> -            if (libxl_gfx_passthru_kind_from_string(buf,
>> &b_info->u.hvm.gfx_passthru_kind)) {
>> -                fprintf(stderr, "ERROR: invalid value \"%s\" for
>> \"gfx_passthru\"\n",
>> -                        buf);
>> +            if (libxl_gfx_passthru_kind_from_string(buf,
>> + &b_info->u.hvm.gfx_passthru_kind)) {
>> +                fprintf(stderr, "ERROR: invalid value \"%s\" for"
>> +                                " \"gfx_passthru\"\n", buf);
>>                   exit (1);
>>               }
>>               libxl_defbool_set(&b_info->u.hvm.gfx_passthru, false);
>>
>
> Your changes are mangled by your email client. But we don't normally
> split the format string so that it's easier to grep.

Yeah.

>
> What we normally do is
>
>       fprintf(stderr,
>               "FORMAT STRING",
> 	     a, b, c);
>
> If format string still treads over 80 column it's fine. We can live
> with that.
>

Understood.

Thanks
Tiejun