From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVBdu-0005pZ-VX for qemu-devel@nongnu.org; Tue, 10 Mar 2015 00:19:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVBdr-0000Ze-Hn for qemu-devel@nongnu.org; Tue, 10 Mar 2015 00:19:42 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:52379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVBdr-0000ZV-9b for qemu-devel@nongnu.org; Tue, 10 Mar 2015 00:19:39 -0400 Message-ID: <54FE70D8.2010904@msgid.tls.msk.ru> Date: Tue, 10 Mar 2015 07:19:36 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1425633831-3101-1-git-send-email-mjt@tls.msk.ru> <1425633831-3101-2-git-send-email-mjt@msgid.tls.msk.ru> <87385f4f5v.fsf@linux.vnet.ibm.com> In-Reply-To: <87385f4f5v.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: qemu-devel@nongnu.org 08.03.2015 19:39, Aneesh Kumar K.V wrote: > Michael Tokarev writes: > >> This simplifies code in v9fs_request() a bit by replacing several >> ifs with a common variable check and rearranging error/cleanup >> code a bit. > > Is this -V2 of > http://mid.gmane.org/b98f675750ef0535cab41225240db1657fc2fe00.1425678142.git.mjt@msgid.tls.msk.ru No, this one (simplify v9fs_reqeust(), P1) was a first version. The above URL points to the v2, a second version. > I am slightly confused with the patch series. It does split the patch as > I wanted, but i am not sure which one is the latest, so that i can start > applying them. That URL points to last. I merged several small patches into larger ones. Initially I thought I just plug a small resource leak so the patch will be small. But the more I understood the code, the bigger the changes were becoming. So at some point it become unreasonable to keep small changes since they're related to bigger changes and since bigger changes touches the same code anyway. Thanks, /mjt