From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YVDJi-0007ap-PZ for mharc-qemu-trivial@gnu.org; Tue, 10 Mar 2015 02:06:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVDJe-0007U9-FZ for qemu-trivial@nongnu.org; Tue, 10 Mar 2015 02:06:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVDJd-0008At-N4 for qemu-trivial@nongnu.org; Tue, 10 Mar 2015 02:06:54 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:55774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVDJY-000893-EB; Tue, 10 Mar 2015 02:06:48 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id D1EEC41302; Tue, 10 Mar 2015 09:06:47 +0300 (MSK) Message-ID: <54FE89F7.1050108@msgid.tls.msk.ru> Date: Tue, 10 Mar 2015 09:06:47 +0300 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Stefan Weil , QEMU Trivial References: <1425766581-18250-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1425766581-18250-1-git-send-email-sw@weilnetz.de> OpenPGP: id=804465C5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.62.121.231 Cc: Kevin Wolf , QEMU Developer , Stefan Hajnoczi Subject: Re: [Qemu-trivial] [PATCH] block/qapi: Fix Sparse warning X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2015 06:06:55 -0000 08.03.2015 01:16, Stefan Weil wrote: > Sparse reports this warning: > > block/qapi.c:417:47: warning: > too long initializer-string for array of char(no space for nul char) > > Replacing the string by an array of characters fixes this warning. > - static const char suffixes[NB_SUFFIXES] = "KMGT"; > + static const char suffixes[NB_SUFFIXES] = {'K', 'M', 'G', 'T'}; The latter is a bit uglier to my taste but oh well, damn warnings! :) Applied to -trivial, thanks! /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVDJc-0007SQ-Mo for qemu-devel@nongnu.org; Tue, 10 Mar 2015 02:06:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVDJY-00089B-KP for qemu-devel@nongnu.org; Tue, 10 Mar 2015 02:06:52 -0400 Message-ID: <54FE89F7.1050108@msgid.tls.msk.ru> Date: Tue, 10 Mar 2015 09:06:47 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1425766581-18250-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1425766581-18250-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block/qapi: Fix Sparse warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , QEMU Trivial Cc: Kevin Wolf , QEMU Developer , Stefan Hajnoczi 08.03.2015 01:16, Stefan Weil wrote: > Sparse reports this warning: > > block/qapi.c:417:47: warning: > too long initializer-string for array of char(no space for nul char) > > Replacing the string by an array of characters fixes this warning. > - static const char suffixes[NB_SUFFIXES] = "KMGT"; > + static const char suffixes[NB_SUFFIXES] = {'K', 'M', 'G', 'T'}; The latter is a bit uglier to my taste but oh well, damn warnings! :) Applied to -trivial, thanks! /mjt