From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, QEMU Trivial <qemu-trivial@nongnu.org>
Cc: QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH 1/7] backends: Fix warning from Sparse
Date: Tue, 10 Mar 2015 09:41:10 +0300 [thread overview]
Message-ID: <54FE9206.1070809@msgid.tls.msk.ru> (raw)
In-Reply-To: <54FE8D8B.3070807@weilnetz.de>
10.03.2015 09:22, Stefan Weil wrote:
> No, that was my mistake. Please excuse also the cris patch which I sent twice.
> I did not notice that it already had caused trouble, nor did I notice that I had already sent it.
> In my local patch queue (~ 50 patches) there was even a 2nd cris patch
> which removed the unused variables...
No problems with that (except that we bothered Peter twice
with this cris thing already, and I really mean "we", since
it escaped my testing and accurate review too, and it was
twice too, so I'm as guilty if not more).
And this situation suggests that I should process and submit
patches a) more carefully and b) faster. So it is, again,
good portion of my fault. Not doing trivial-patches merging
for 3 weeks and rushing a whole lot in one go without that
good review isn't going to work well.
Thank you for the good work! And it really is good, while
boring...
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, QEMU Trivial <qemu-trivial@nongnu.org>
Cc: QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse
Date: Tue, 10 Mar 2015 09:41:10 +0300 [thread overview]
Message-ID: <54FE9206.1070809@msgid.tls.msk.ru> (raw)
In-Reply-To: <54FE8D8B.3070807@weilnetz.de>
10.03.2015 09:22, Stefan Weil wrote:
> No, that was my mistake. Please excuse also the cris patch which I sent twice.
> I did not notice that it already had caused trouble, nor did I notice that I had already sent it.
> In my local patch queue (~ 50 patches) there was even a 2nd cris patch
> which removed the unused variables...
No problems with that (except that we bothered Peter twice
with this cris thing already, and I really mean "we", since
it escaped my testing and accurate review too, and it was
twice too, so I'm as guilty if not more).
And this situation suggests that I should process and submit
patches a) more carefully and b) faster. So it is, again,
good portion of my fault. Not doing trivial-patches merging
for 3 weeks and rushing a whole lot in one go without that
good review isn't going to work well.
Thank you for the good work! And it really is good, while
boring...
/mjt
next prev parent reply other threads:[~2015-03-10 6:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 18:14 [Qemu-trivial] [PATCH 1/7] backends: Fix warning from Sparse Stefan Weil
2015-03-08 18:14 ` [Qemu-devel] " Stefan Weil
2015-03-10 6:04 ` [Qemu-trivial] " Michael Tokarev
2015-03-10 6:04 ` [Qemu-devel] " Michael Tokarev
2015-03-10 6:22 ` [Qemu-trivial] " Stefan Weil
2015-03-10 6:22 ` [Qemu-devel] " Stefan Weil
2015-03-10 6:41 ` Michael Tokarev [this message]
2015-03-10 6:41 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FE9206.1070809@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.