All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: Dirk Nehring <dnehring@gmx.net>, linux-media@vger.kernel.org
Cc: "nibble.max" <nibble.max@gmail.com>
Subject: Re: [PATCH 1/1] Fix DVBsky rc-keymap
Date: Tue, 10 Mar 2015 09:53:04 +0200	[thread overview]
Message-ID: <54FEA2E0.8090405@iki.fi> (raw)
In-Reply-To: <1425938573-7107-1-git-send-email-dnehring@gmx.net>



On 03/10/2015 12:02 AM, Dirk Nehring wrote:
> Signed-off-by: Dirk Nehring <dnehring@gmx.net>
> ---
>   drivers/media/rc/keymaps/rc-dvbsky.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/rc/keymaps/rc-dvbsky.c b/drivers/media/rc/keymaps/rc-dvbsky.c
> index c5115a1..b942b16 100644
> --- a/drivers/media/rc/keymaps/rc-dvbsky.c
> +++ b/drivers/media/rc/keymaps/rc-dvbsky.c
> @@ -33,16 +33,16 @@ static struct rc_map_table rc5_dvbsky[] = {
>   	{ 0x000b, KEY_STOP },
>   	{ 0x000c, KEY_EXIT },
>   	{ 0x000e, KEY_CAMERA }, /*Snap shot*/
> -	{ 0x000f, KEY_SUBTITLE }, /*PIP*/
> -	{ 0x0010, KEY_VOLUMEUP },
> -	{ 0x0011, KEY_VOLUMEDOWN },
> +	{ 0x000f, KEY_TV2 }, /*PIP*/

I don't know what kind of layout there really is, but according to 
comment that button is PIP which should be KEY_NEW. I wonder if you 
mapped those UP/DOWN buttons also badly...

http://linuxtv.org/wiki/index.php/Remote_Controllers



> +	{ 0x0010, KEY_RIGHT },
> +	{ 0x0011, KEY_LEFT },
>   	{ 0x0012, KEY_FAVORITES },
> -	{ 0x0013, KEY_LIST }, /*Info*/
> +	{ 0x0013, KEY_INFO },
>   	{ 0x0016, KEY_PAUSE },
>   	{ 0x0017, KEY_PLAY },
>   	{ 0x001f, KEY_RECORD },
> -	{ 0x0020, KEY_CHANNELDOWN },
> -	{ 0x0021, KEY_CHANNELUP },
> +	{ 0x0020, KEY_UP },
> +	{ 0x0021, KEY_DOWN },
>   	{ 0x0025, KEY_POWER2 },
>   	{ 0x0026, KEY_REWIND },
>   	{ 0x0027, KEY_FASTFORWARD },
>

-- 
http://palosaari.fi/

  reply	other threads:[~2015-03-10  7:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 22:02 [PATCH 1/1] Fix DVBsky rc-keymap Dirk Nehring
2015-03-10  7:53 ` Antti Palosaari [this message]
2015-03-10  8:16   ` Dirk Nehring
  -- strict thread matches above, loose matches on Subject: below --
2015-03-10  1:48 Nibble Max
2015-03-10  8:04 ` Dirk Nehring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FEA2E0.8090405@iki.fi \
    --to=crope@iki.fi \
    --cc=dnehring@gmx.net \
    --cc=linux-media@vger.kernel.org \
    --cc=nibble.max@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.