From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC 1/6] drm: Add top level Kconfig option for DRM fbdev emulation Date: Tue, 10 Mar 2015 15:22:49 +0530 Message-ID: <54FEBEF1.5000103@codeaurora.org> References: <1425980493-27533-1-git-send-email-architt@codeaurora.org> <1425980493-27533-2-git-send-email-architt@codeaurora.org> <20150310094756.GE3800@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150310094756.GE3800@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: robdclark@gmail.com, airlied@linux.ie, treding@nvidia.com, p.zabel@pengutronix.de, benjamin.gaignard@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, daniel@ffwll.ch, daniel.vetter@ffwll.ch List-Id: linux-arm-msm@vger.kernel.org CgpPbiAwMy8xMC8yMDE1IDAzOjE3IFBNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IE9uIFR1ZSwg TWFyIDEwLCAyMDE1IGF0IDAzOjExOjI4UE0gKzA1MzAsIEFyY2hpdCBUYW5lamEgd3JvdGU6Cj4+ IExlZ2FjeSBmYmRldiBlbXVsYXRpb24gc3VwcG9ydCB2aWEgRFJNIGlzIGFjaGlldmVkIHRocm91 Z2ggS01TIEZCIGhlbHBlcnMuCj4+IE1vc3QgbW9kZXNldHRpbmcgZHJpdmVycyBlbmFibGUgcHJv dmlkZSBmYmRldiBlbXVsYXRpb24gYnkgZGVmYXVsdCBieSBzZWxlY3RpbmcKPj4gS01TIEZCIGhl bHBlcnMuIEEgZmV3IHByb3ZpZGUgYSBzZXBhcmF0ZSBLY29uZmlnIG9wdGlvbiBmb3IgdGhlIHVz ZXIgdG8gZW5hYmxlCj4+IG9yIGRpc2JhbGUgZmJkZXYgZW11bGF0aW9uLgo+Pgo+PiBFbmFibGlu ZyBmYmRldiBlbXVsYXRpb24gaXMgZmluYWxseSBhIGRpc3Ryby1sZXZlbCBkZWNpc2lvbi4gSGF2 aW5nIGEgdG9wIGxldmVsCj4+IEtjb25maWcgb3B0aW9uIGZvciBmYmRldiBlbXVsYXRpb24gaGVs cHMgYnkgcHJvdmlkaW5nIGEgdW5pZm9ybSB3YXkgdG8KPj4gZW5hYmxlL2Rpc2FibGUgZmJkZXYg ZW11bGF0aW9uIGZvciBhbnkgbW9kZXNldHRpbmcgZHJpdmVyLiBJdCBhbHNvIGxldHMgdXMKPj4g cmVtb3ZlIHVubmVjZXNzYXJ5IGRyaXZlciBzcGVjaWZpYyBLY29uZmlnIG9wdGlvbnMgdGhhdCBj YXVzZXMgYmxvYXQuCj4+Cj4+IFdpdGggYSB0b3AgbGV2ZWwgS2NvbmZpZyBpbiBwbGFjZSwgd2Ug Y2FuIHN0dWIgb3V0IHRoZSBmYiBoZWxwZXIgZnVuY3Rpb25zIHdoZW4KPj4gbm90IG5lZWRlZCB3 aXRob3V0IGJyZWFraW5nIGZ1bmN0aW9uYWxpdHkuIEhhdmluZyBzdHViIGZ1bmN0aW9ucyBhbHNv IHByZXZlbnRzCj4+IGRyaXZlcnMgdG8gcmVxdWlyZSB3cmFwcGluZyBmYiBoZWxwZXIgZnVuY3Rp b24gY2FsbHMgd2l0aCAjaWZkZWZzLgo+Pgo+PiBEUk1fRkJERVZfRU1VTEFUSU9OIGRlZmF1bHRz IHRvIHkgc2luY2UgbWFueSBkcml2ZXJzIGVuYWJsZSBmYmRldiBlbXVsYXRpb24gYnkKPj4gZGVm YXVsdCBhbmQgbWFqb3JpdHkgb2YgZGlzdHJpYnV0aW9ucyBleHBlY3QgdGhlIGZiZGV2IGludGVy ZmFjZSBpbiB0aGUga2VybmVsLgo+Pgo+PiBGb3Igbm93LCB0aGlzIGNvbmZpZyBzZWxlY3RzIGJv dGggRkJfU1lTXyogYW5kIEZCX0NGQl8qIGNvbmZpZ3MgYXMgc29tZQo+PiBtb2Rlc2V0dGluZyBk cml2ZXJzIHVzZSB0aGUgZm9ybWVyIGFuZCBvdGhlciB0aGUgbGF0ZXIuIFRoaXMgbmVlZHMgdG8g YmUgdGFrZW4KPj4gY2FyZSBvZiBpbiBhIGJldHRlciB3YXkuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6 IEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+Cj4+IC0tLQo+PiAgIGRyaXZl cnMvZ3B1L2RybS9LY29uZmlnICAgICB8ICAxOCArKysrKysrCj4+ICAgZHJpdmVycy9ncHUvZHJt L01ha2VmaWxlICAgIHwgICA0ICsrCj4+ICAgaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oIHwg MTIwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+ICAgMyBm aWxlcyBjaGFuZ2VkLCAxNDIgaW5zZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL0tjb25maWcgYi9kcml2ZXJzL2dwdS9kcm0vS2NvbmZpZwo+PiBpbmRleCAxNTFh MDUwLi4zOGY4M2EwIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vS2NvbmZpZwo+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vS2NvbmZpZwo+PiBAQCAtNDAsNiArNDAsMjQgQEAgY29uZmln IERSTV9LTVNfRkJfSEVMUEVSCj4+ICAgCWhlbHAKPj4gICAJICBGQkRFViBoZWxwZXJzIGZvciBL TVMgZHJpdmVycy4KPj4KPj4gK2NvbmZpZyBEUk1fRkJERVZfRU1VTEFUSU9OCj4+ICsJYm9vbCAi RW5hYmxlIGxlZ2FjeSBmYmRldiBzdXBwb3J0IGZvciB5b3VyIG1vZGVzZXR0aW5nIGRyaXZlciIK Pj4gKwlkZXBlbmRzIG9uIERSTQo+PiArCXNlbGVjdCBEUk1fS01TX0hFTFBFUgo+PiArCXNlbGVj dCBEUk1fS01TX0ZCX0hFTFBFUgo+PiArCXNlbGVjdCBGQl9TWVNfRklMTFJFQ1QKPj4gKwlzZWxl Y3QgRkJfU1lTX0NPUFlBUkVBCj4+ICsJc2VsZWN0IEZCX1NZU19JTUFHRUJMSVQKPj4gKwlzZWxl Y3QgRkJfU1lTX0ZPUFMKPj4gKwlzZWxlY3QgRkJfQ0ZCX0ZJTExSRUNUCj4+ICsJc2VsZWN0IEZC X0NGQl9DT1BZQVJFQQo+PiArCXNlbGVjdCBGQl9DRkJfSU1BR0VCTElUCj4+ICsJZGVmYXVsdCB5 Cj4+ICsJaGVscAo+PiArCSAgQ2hvb3NlIHRoaXMgb3B0aW9uIGlmIHlvdSBoYXZlIGEgbmVlZCBm b3IgdGhlIGxlZ2FjeSBmYmRldgo+PiArCSAgc3VwcG9ydC4gTm90ZSB0aGF0IHRoaXMgc3VwcG9y dCBhbHNvIHByb3ZpZGUgdGhlIGxpbnV4IGNvbnNvbGUKPj4gKwkgIHN1cHBvcnQgb24gdG9wIG9m IHlvdXIgbW9kZXNldHRpbmcgZHJpdmVyLgo+Cj4gTWF5YmUgY2xhcmlmeSB0aGF0IGZvciBsaW51 eCBjb25zb2xlIHN1cHBvcnQgeW91IGFsc28gbmVlZAo+IENPTkZJR19GUkFNRUJVRkZFUl9DT05T T0xFPyBmYmRldiBhbG9uZSBpc24ndCBlbm91Z2guCgpEUk1fS01TX0ZCX0hFTFBFUiBzZWxlY3Rz IHRoYXQgZm9yIHVzLCByaWdodD8KCkFyY2hpdApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751970AbbCJJw7 (ORCPT ); Tue, 10 Mar 2015 05:52:59 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60042 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbbCJJw5 (ORCPT ); Tue, 10 Mar 2015 05:52:57 -0400 Message-ID: <54FEBEF1.5000103@codeaurora.org> Date: Tue, 10 Mar 2015 15:22:49 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: robdclark@gmail.com, airlied@linux.ie, treding@nvidia.com, p.zabel@pengutronix.de, benjamin.gaignard@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, daniel@ffwll.ch, daniel.vetter@ffwll.ch Subject: Re: [RFC 1/6] drm: Add top level Kconfig option for DRM fbdev emulation References: <1425980493-27533-1-git-send-email-architt@codeaurora.org> <1425980493-27533-2-git-send-email-architt@codeaurora.org> <20150310094756.GE3800@phenom.ffwll.local> In-Reply-To: <20150310094756.GE3800@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2015 03:17 PM, Daniel Vetter wrote: > On Tue, Mar 10, 2015 at 03:11:28PM +0530, Archit Taneja wrote: >> Legacy fbdev emulation support via DRM is achieved through KMS FB helpers. >> Most modesetting drivers enable provide fbdev emulation by default by selecting >> KMS FB helpers. A few provide a separate Kconfig option for the user to enable >> or disbale fbdev emulation. >> >> Enabling fbdev emulation is finally a distro-level decision. Having a top level >> Kconfig option for fbdev emulation helps by providing a uniform way to >> enable/disable fbdev emulation for any modesetting driver. It also lets us >> remove unnecessary driver specific Kconfig options that causes bloat. >> >> With a top level Kconfig in place, we can stub out the fb helper functions when >> not needed without breaking functionality. Having stub functions also prevents >> drivers to require wrapping fb helper function calls with #ifdefs. >> >> DRM_FBDEV_EMULATION defaults to y since many drivers enable fbdev emulation by >> default and majority of distributions expect the fbdev interface in the kernel. >> >> For now, this config selects both FB_SYS_* and FB_CFB_* configs as some >> modesetting drivers use the former and other the later. This needs to be taken >> care of in a better way. >> >> Signed-off-by: Archit Taneja >> --- >> drivers/gpu/drm/Kconfig | 18 +++++++ >> drivers/gpu/drm/Makefile | 4 ++ >> include/drm/drm_fb_helper.h | 120 ++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 142 insertions(+) >> >> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >> index 151a050..38f83a0 100644 >> --- a/drivers/gpu/drm/Kconfig >> +++ b/drivers/gpu/drm/Kconfig >> @@ -40,6 +40,24 @@ config DRM_KMS_FB_HELPER >> help >> FBDEV helpers for KMS drivers. >> >> +config DRM_FBDEV_EMULATION >> + bool "Enable legacy fbdev support for your modesetting driver" >> + depends on DRM >> + select DRM_KMS_HELPER >> + select DRM_KMS_FB_HELPER >> + select FB_SYS_FILLRECT >> + select FB_SYS_COPYAREA >> + select FB_SYS_IMAGEBLIT >> + select FB_SYS_FOPS >> + select FB_CFB_FILLRECT >> + select FB_CFB_COPYAREA >> + select FB_CFB_IMAGEBLIT >> + default y >> + help >> + Choose this option if you have a need for the legacy fbdev >> + support. Note that this support also provide the linux console >> + support on top of your modesetting driver. > > Maybe clarify that for linux console support you also need > CONFIG_FRAMEBUFFER_CONSOLE? fbdev alone isn't enough. DRM_KMS_FB_HELPER selects that for us, right? Archit