From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC 1/6] drm: Add top level Kconfig option for DRM fbdev emulation Date: Tue, 10 Mar 2015 15:52:41 +0530 Message-ID: <54FEC5F1.90208@codeaurora.org> References: <1425980493-27533-1-git-send-email-architt@codeaurora.org> <1425980493-27533-2-git-send-email-architt@codeaurora.org> <20150310094756.GE3800@phenom.ffwll.local> <54FEBEF1.5000103@codeaurora.org> <20150310100547.GG3800@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150310100547.GG3800@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: robdclark@gmail.com, airlied@linux.ie, treding@nvidia.com, p.zabel@pengutronix.de, benjamin.gaignard@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, daniel@ffwll.ch List-Id: linux-arm-msm@vger.kernel.org CgpPbiAwMy8xMC8yMDE1IDAzOjM1IFBNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IE9uIFR1ZSwg TWFyIDEwLCAyMDE1IGF0IDAzOjIyOjQ5UE0gKzA1MzAsIEFyY2hpdCBUYW5lamEgd3JvdGU6Cj4+ Cj4+Cj4+IE9uIDAzLzEwLzIwMTUgMDM6MTcgUE0sIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+PiBP biBUdWUsIE1hciAxMCwgMjAxNSBhdCAwMzoxMToyOFBNICswNTMwLCBBcmNoaXQgVGFuZWphIHdy b3RlOgo+Pj4+IExlZ2FjeSBmYmRldiBlbXVsYXRpb24gc3VwcG9ydCB2aWEgRFJNIGlzIGFjaGll dmVkIHRocm91Z2ggS01TIEZCIGhlbHBlcnMuCj4+Pj4gTW9zdCBtb2Rlc2V0dGluZyBkcml2ZXJz IGVuYWJsZSBwcm92aWRlIGZiZGV2IGVtdWxhdGlvbiBieSBkZWZhdWx0IGJ5IHNlbGVjdGluZwo+ Pj4+IEtNUyBGQiBoZWxwZXJzLiBBIGZldyBwcm92aWRlIGEgc2VwYXJhdGUgS2NvbmZpZyBvcHRp b24gZm9yIHRoZSB1c2VyIHRvIGVuYWJsZQo+Pj4+IG9yIGRpc2JhbGUgZmJkZXYgZW11bGF0aW9u Lgo+Pj4+Cj4+Pj4gRW5hYmxpbmcgZmJkZXYgZW11bGF0aW9uIGlzIGZpbmFsbHkgYSBkaXN0cm8t bGV2ZWwgZGVjaXNpb24uIEhhdmluZyBhIHRvcCBsZXZlbAo+Pj4+IEtjb25maWcgb3B0aW9uIGZv ciBmYmRldiBlbXVsYXRpb24gaGVscHMgYnkgcHJvdmlkaW5nIGEgdW5pZm9ybSB3YXkgdG8KPj4+ PiBlbmFibGUvZGlzYWJsZSBmYmRldiBlbXVsYXRpb24gZm9yIGFueSBtb2Rlc2V0dGluZyBkcml2 ZXIuIEl0IGFsc28gbGV0cyB1cwo+Pj4+IHJlbW92ZSB1bm5lY2Vzc2FyeSBkcml2ZXIgc3BlY2lm aWMgS2NvbmZpZyBvcHRpb25zIHRoYXQgY2F1c2VzIGJsb2F0Lgo+Pj4+Cj4+Pj4gV2l0aCBhIHRv cCBsZXZlbCBLY29uZmlnIGluIHBsYWNlLCB3ZSBjYW4gc3R1YiBvdXQgdGhlIGZiIGhlbHBlciBm dW5jdGlvbnMgd2hlbgo+Pj4+IG5vdCBuZWVkZWQgd2l0aG91dCBicmVha2luZyBmdW5jdGlvbmFs aXR5LiBIYXZpbmcgc3R1YiBmdW5jdGlvbnMgYWxzbyBwcmV2ZW50cwo+Pj4+IGRyaXZlcnMgdG8g cmVxdWlyZSB3cmFwcGluZyBmYiBoZWxwZXIgZnVuY3Rpb24gY2FsbHMgd2l0aCAjaWZkZWZzLgo+ Pj4+Cj4+Pj4gRFJNX0ZCREVWX0VNVUxBVElPTiBkZWZhdWx0cyB0byB5IHNpbmNlIG1hbnkgZHJp dmVycyBlbmFibGUgZmJkZXYgZW11bGF0aW9uIGJ5Cj4+Pj4gZGVmYXVsdCBhbmQgbWFqb3JpdHkg b2YgZGlzdHJpYnV0aW9ucyBleHBlY3QgdGhlIGZiZGV2IGludGVyZmFjZSBpbiB0aGUga2VybmVs Lgo+Pj4+Cj4+Pj4gRm9yIG5vdywgdGhpcyBjb25maWcgc2VsZWN0cyBib3RoIEZCX1NZU18qIGFu ZCBGQl9DRkJfKiBjb25maWdzIGFzIHNvbWUKPj4+PiBtb2Rlc2V0dGluZyBkcml2ZXJzIHVzZSB0 aGUgZm9ybWVyIGFuZCBvdGhlciB0aGUgbGF0ZXIuIFRoaXMgbmVlZHMgdG8gYmUgdGFrZW4KPj4+ PiBjYXJlIG9mIGluIGEgYmV0dGVyIHdheS4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IEFyY2hp dCBUYW5lamEgPGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+Cj4+Pj4gLS0tCj4+Pj4gICBkcml2ZXJz L2dwdS9kcm0vS2NvbmZpZyAgICAgfCAgMTggKysrKysrKwo+Pj4+ICAgZHJpdmVycy9ncHUvZHJt L01ha2VmaWxlICAgIHwgICA0ICsrCj4+Pj4gICBpbmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmgg fCAxMjAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPj4+PiAg IDMgZmlsZXMgY2hhbmdlZCwgMTQyIGluc2VydGlvbnMoKykKPj4+Pgo+Pj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vS2NvbmZpZyBiL2RyaXZlcnMvZ3B1L2RybS9LY29uZmlnCj4+Pj4g aW5kZXggMTUxYTA1MC4uMzhmODNhMCAxMDA2NDQKPj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v S2NvbmZpZwo+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9LY29uZmlnCj4+Pj4gQEAgLTQwLDYg KzQwLDI0IEBAIGNvbmZpZyBEUk1fS01TX0ZCX0hFTFBFUgo+Pj4+ICAgCWhlbHAKPj4+PiAgIAkg IEZCREVWIGhlbHBlcnMgZm9yIEtNUyBkcml2ZXJzLgo+Pj4+Cj4+Pj4gK2NvbmZpZyBEUk1fRkJE RVZfRU1VTEFUSU9OCj4+Pj4gKwlib29sICJFbmFibGUgbGVnYWN5IGZiZGV2IHN1cHBvcnQgZm9y IHlvdXIgbW9kZXNldHRpbmcgZHJpdmVyIgo+Pj4+ICsJZGVwZW5kcyBvbiBEUk0KPj4+PiArCXNl bGVjdCBEUk1fS01TX0hFTFBFUgo+Pj4+ICsJc2VsZWN0IERSTV9LTVNfRkJfSEVMUEVSCj4+Pj4g KwlzZWxlY3QgRkJfU1lTX0ZJTExSRUNUCj4+Pj4gKwlzZWxlY3QgRkJfU1lTX0NPUFlBUkVBCj4+ Pj4gKwlzZWxlY3QgRkJfU1lTX0lNQUdFQkxJVAo+Pj4+ICsJc2VsZWN0IEZCX1NZU19GT1BTCj4+ Pj4gKwlzZWxlY3QgRkJfQ0ZCX0ZJTExSRUNUCj4+Pj4gKwlzZWxlY3QgRkJfQ0ZCX0NPUFlBUkVB Cj4+Pj4gKwlzZWxlY3QgRkJfQ0ZCX0lNQUdFQkxJVAo+Pj4+ICsJZGVmYXVsdCB5Cj4+Pj4gKwlo ZWxwCj4+Pj4gKwkgIENob29zZSB0aGlzIG9wdGlvbiBpZiB5b3UgaGF2ZSBhIG5lZWQgZm9yIHRo ZSBsZWdhY3kgZmJkZXYKPj4+PiArCSAgc3VwcG9ydC4gTm90ZSB0aGF0IHRoaXMgc3VwcG9ydCBh bHNvIHByb3ZpZGUgdGhlIGxpbnV4IGNvbnNvbGUKPj4+PiArCSAgc3VwcG9ydCBvbiB0b3Agb2Yg eW91ciBtb2Rlc2V0dGluZyBkcml2ZXIuCj4+Pgo+Pj4gTWF5YmUgY2xhcmlmeSB0aGF0IGZvciBs aW51eCBjb25zb2xlIHN1cHBvcnQgeW91IGFsc28gbmVlZAo+Pj4gQ09ORklHX0ZSQU1FQlVGRkVS X0NPTlNPTEU/IGZiZGV2IGFsb25lIGlzbid0IGVub3VnaC4KPj4KPj4gRFJNX0tNU19GQl9IRUxQ RVIgc2VsZWN0cyB0aGF0IGZvciB1cywgcmlnaHQ/Cj4KPiBIbSByaWdodCBJJ3ZlIG1pc3NlZCB0 aGF0LiBSZW1pbmRzIG1lIHRoYXQgeW91IG5lZWQgb25lIG1vcmUgcGF0Y2ggYXQgdGhlCj4gZW5k IHRvIHJlbW92ZSBhbGwgdGhlIHZhcmlvdXMgc2VsZWN0IERSTV9LTVNfRkJfSEVMUEVSIGZyb20g YWxsIGRybQo+IGRyaXZlcnMuIE90aGVyd2lzZSB0aGlzIGtub2IgaGVyZSB3b24ndCB3b3JrIGJ5 IGRlZmF1bHQgaWYgeW91IGUuZy4gc2VsZWN0Cj4gcmFkZW9uLiBJbiBnZW5lcmFsIHdlIGNhbid0 IG1peCBleHBsaWNpdCBvcHRpb25zIHdpdGggbWVudSBlbnRyaWVzIHdpdGggYQo+IHNlbGVjdC4K Ckkgd2FzIHRyeWluZyB0aGF0IG91dC4gUmVtb3ZpbmcgRFJNX0tNU19GQl9IRUxQRVIgYW5kIGhh dmluZyAKRFJNX0ZCREVWX0VNVUxBVElPTiBkaXNhYmxlZCBicmVha3MgZHJpdmVycyB3aGljaCB1 c2UgRkIgc3R1ZmYgCmludGVybmFsbHkgaW4gdGhlaXIgcmVzcGVjdGl2ZSB4eXpfZmJkZXYuYyBm aWxlcy4KCkFyZSB5b3Ugc2F5aW5nIHRoYXQgd2Ugc2hvdWxkIHJlbW92ZSBEUk1fS01TX0ZCX0hF TFBFUiBmb3Igc3VjaCBkcml2ZXJzIAphbmQgcmVwbGFjZSB0aGVtIHdpdGggJ3NlbGVjdCBEUk1f RkJERVZfRU1VTEFUSU9OJz8KCkFub3RoZXIgb3B0aW9uIHdvdWxkIGJlIHRvIHByb3ZpZGUgI2lm ZGVmIERSTV9GQkRFVl9FTVVMQVRJT04gCndyYXAtYXJvdW5kcyBmb3IgZmIgcmVsYXRlZCBmdW5j dGlvbiBjYWxscy9kZWNsYXJhdGlvbnMgaW4gZWFjaCBkcml2ZXIsIApzb21ldGhpbmcgdGhhdCdz IGFscmVhZHkgZG9uZSBmb3IgaTkxNSBhbmQgbXNtIGRyaXZlcnMuCgpBcmNoaXQKCi0tIApRdWFs Y29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiBDb2RlIEF1cm9yYSBG b3J1bSwKYSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752652AbbCJKWu (ORCPT ); Tue, 10 Mar 2015 06:22:50 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34846 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945AbbCJKWr (ORCPT ); Tue, 10 Mar 2015 06:22:47 -0400 Message-ID: <54FEC5F1.90208@codeaurora.org> Date: Tue, 10 Mar 2015 15:52:41 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: robdclark@gmail.com, airlied@linux.ie, treding@nvidia.com, p.zabel@pengutronix.de, benjamin.gaignard@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, daniel@ffwll.ch Subject: Re: [RFC 1/6] drm: Add top level Kconfig option for DRM fbdev emulation References: <1425980493-27533-1-git-send-email-architt@codeaurora.org> <1425980493-27533-2-git-send-email-architt@codeaurora.org> <20150310094756.GE3800@phenom.ffwll.local> <54FEBEF1.5000103@codeaurora.org> <20150310100547.GG3800@phenom.ffwll.local> In-Reply-To: <20150310100547.GG3800@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2015 03:35 PM, Daniel Vetter wrote: > On Tue, Mar 10, 2015 at 03:22:49PM +0530, Archit Taneja wrote: >> >> >> On 03/10/2015 03:17 PM, Daniel Vetter wrote: >>> On Tue, Mar 10, 2015 at 03:11:28PM +0530, Archit Taneja wrote: >>>> Legacy fbdev emulation support via DRM is achieved through KMS FB helpers. >>>> Most modesetting drivers enable provide fbdev emulation by default by selecting >>>> KMS FB helpers. A few provide a separate Kconfig option for the user to enable >>>> or disbale fbdev emulation. >>>> >>>> Enabling fbdev emulation is finally a distro-level decision. Having a top level >>>> Kconfig option for fbdev emulation helps by providing a uniform way to >>>> enable/disable fbdev emulation for any modesetting driver. It also lets us >>>> remove unnecessary driver specific Kconfig options that causes bloat. >>>> >>>> With a top level Kconfig in place, we can stub out the fb helper functions when >>>> not needed without breaking functionality. Having stub functions also prevents >>>> drivers to require wrapping fb helper function calls with #ifdefs. >>>> >>>> DRM_FBDEV_EMULATION defaults to y since many drivers enable fbdev emulation by >>>> default and majority of distributions expect the fbdev interface in the kernel. >>>> >>>> For now, this config selects both FB_SYS_* and FB_CFB_* configs as some >>>> modesetting drivers use the former and other the later. This needs to be taken >>>> care of in a better way. >>>> >>>> Signed-off-by: Archit Taneja >>>> --- >>>> drivers/gpu/drm/Kconfig | 18 +++++++ >>>> drivers/gpu/drm/Makefile | 4 ++ >>>> include/drm/drm_fb_helper.h | 120 ++++++++++++++++++++++++++++++++++++++++++++ >>>> 3 files changed, 142 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >>>> index 151a050..38f83a0 100644 >>>> --- a/drivers/gpu/drm/Kconfig >>>> +++ b/drivers/gpu/drm/Kconfig >>>> @@ -40,6 +40,24 @@ config DRM_KMS_FB_HELPER >>>> help >>>> FBDEV helpers for KMS drivers. >>>> >>>> +config DRM_FBDEV_EMULATION >>>> + bool "Enable legacy fbdev support for your modesetting driver" >>>> + depends on DRM >>>> + select DRM_KMS_HELPER >>>> + select DRM_KMS_FB_HELPER >>>> + select FB_SYS_FILLRECT >>>> + select FB_SYS_COPYAREA >>>> + select FB_SYS_IMAGEBLIT >>>> + select FB_SYS_FOPS >>>> + select FB_CFB_FILLRECT >>>> + select FB_CFB_COPYAREA >>>> + select FB_CFB_IMAGEBLIT >>>> + default y >>>> + help >>>> + Choose this option if you have a need for the legacy fbdev >>>> + support. Note that this support also provide the linux console >>>> + support on top of your modesetting driver. >>> >>> Maybe clarify that for linux console support you also need >>> CONFIG_FRAMEBUFFER_CONSOLE? fbdev alone isn't enough. >> >> DRM_KMS_FB_HELPER selects that for us, right? > > Hm right I've missed that. Reminds me that you need one more patch at the > end to remove all the various select DRM_KMS_FB_HELPER from all drm > drivers. Otherwise this knob here won't work by default if you e.g. select > radeon. In general we can't mix explicit options with menu entries with a > select. I was trying that out. Removing DRM_KMS_FB_HELPER and having DRM_FBDEV_EMULATION disabled breaks drivers which use FB stuff internally in their respective xyz_fbdev.c files. Are you saying that we should remove DRM_KMS_FB_HELPER for such drivers and replace them with 'select DRM_FBDEV_EMULATION'? Another option would be to provide #ifdef DRM_FBDEV_EMULATION wrap-arounds for fb related function calls/declarations in each driver, something that's already done for i915 and msm drivers. Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project