All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Daniel Kiper <daniel.kiper@oracle.com>
Subject: Re: [PATCHv1] xen/balloon: disable memory hotplug in PV guests
Date: Tue, 10 Mar 2015 11:40:35 +0000	[thread overview]
Message-ID: <54FED833.1080609@citrix.com> (raw)
In-Reply-To: <1425910200-17541-1-git-send-email-david.vrabel@citrix.com>

On 09/03/15 14:10, David Vrabel wrote:
> Memory hotplug doesn't work with PV guests because:
> 
>   a) The p2m cannot be expanded to cover the new sections.

Broken by 054954eb051f35e74b75a566a96fe756015352c8 (xen: switch to
linear virtual mapped sparse p2m list).

This one would be non-trivial to fix.  We'd need a sparse set of
vm_area's for the p2m or similar.

>   b) add_memory() builds page tables for the new sections which means
>      the new pages must have valid p2m entries (or a BUG occurs).

After some more testing this appears to be broken by:

25b884a83d487fd62c3de7ac1ab5549979188482 (x86/xen: set regions above the
end of RAM as 1:1) included 3.16.

This one can be trivially fixed by setting the new sections in the p2m
to INVALID_P2M_ENTRY before calling add_memory().

David

  parent reply	other threads:[~2015-03-10 11:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 14:10 [PATCHv1] xen/balloon: disable memory hotplug in PV guests David Vrabel
2015-03-09 15:09 ` Boris Ostrovsky
2015-03-09 15:13   ` David Vrabel
2015-03-09 15:25     ` Boris Ostrovsky
2015-03-09 15:31       ` David Vrabel
2015-03-09 15:40         ` Konrad Rzeszutek Wilk
2015-03-09 15:50         ` Boris Ostrovsky
2015-03-09 20:45         ` Daniel Kiper
2015-03-09 20:22       ` Daniel Kiper
2015-03-10 11:40 ` David Vrabel [this message]
2015-03-10 13:35   ` Boris Ostrovsky
2015-03-11 14:42     ` David Vrabel
2015-03-11 15:40       ` Boris Ostrovsky
2015-03-16  5:35         ` Juergen Gross
2015-03-16 10:03           ` Daniel Kiper
2015-03-16 10:31             ` Juergen Gross
2015-03-17 12:40               ` Daniel Kiper
2015-03-17 13:00                 ` Juergen Gross
2015-03-18 10:36               ` David Vrabel
2015-03-18 13:57                 ` Juergen Gross
2015-03-18 13:59                   ` David Vrabel
2015-03-18 15:14                     ` Daniel Kiper
2015-03-19  9:55                       ` Juergen Gross
2015-03-19 11:34                         ` Daniel Kiper
2015-03-19 13:38                           ` Juergen Gross
2015-03-19 14:21                             ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FED833.1080609@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.