From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: gic: GICv2 & GICv3 only supports 1020 physical interrupts Date: Tue, 10 Mar 2015 11:46:54 +0000 Message-ID: <54FED9AE.2050107@linaro.org> References: <1425400555-14725-1-git-send-email-julien.grall@linaro.org> <1425574810.25940.271.camel@citrix.com> <54FD8B5B.2050809@linaro.org> <1425917170.21353.34.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YVId9-0003eK-FC for xen-devel@lists.xenproject.org; Tue, 10 Mar 2015 11:47:23 +0000 Received: by wiwh11 with SMTP id h11so19040486wiw.1 for ; Tue, 10 Mar 2015 04:47:21 -0700 (PDT) In-Reply-To: <1425917170.21353.34.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 09/03/15 16:06, Ian Campbell wrote: > On Mon, 2015-03-09 at 14:00 +0200, Julien Grall wrote: >> Hi Ian, >> >> On 05/03/2015 19:00, Ian Campbell wrote: >>> On Tue, 2015-03-03 at 16:35 +0000, Julien Grall wrote: >>>> + gicv3_info.nr_lines = min((unsigned)1020, nr_lines); >>> >>> "1020U" is the correct way to write (unsigned)1020 I think (in both >>> places). >> >> I gave a look on several usage of min in arch/arm and (unsigned) was used. > > I don't see any with a literal number, which is the main point. > (unsigned)PAGE_SIZE is fine, because you can't write PAGE_SIZEU very > easily. (Leaving aside whether PAGE_SIZE should be unsigned in its > definition. Hmmm ... right. I will update the patch. Regards, -- Julien Grall