From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVIfv-0000i6-HH for qemu-devel@nongnu.org; Tue, 10 Mar 2015 07:50:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVIfq-00046M-Br for qemu-devel@nongnu.org; Tue, 10 Mar 2015 07:50:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58799 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVIfq-000468-6O for qemu-devel@nongnu.org; Tue, 10 Mar 2015 07:50:10 -0400 Message-ID: <54FEDA6F.9000802@suse.de> Date: Tue, 10 Mar 2015 12:50:07 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1425576411-32639-1-git-send-email-ehabkost@redhat.com> <1425576411-32639-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1425576411-32639-2-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: zhugh.fnst@cn.fujitsu.com, "Michael S. Tsirkin" , tangchen@cn.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Paolo Bonzini , Gu Zheng , Igor Mammedov , anshul.makkar@profitbricks.com Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: > Instead of passing icc_bridge from the PC initialization code to > cpu_x86_create(), make the PC initialization code attach the CPU to > icc_bridge. >=20 > The only difference here is that icc_bridge attachment will now be done > after x86_cpu_parse_featurestr() is called. But this shouldn't make any > difference, as property setters shouldn't depend on icc_bridge. >=20 > Signed-off-by: Eduardo Habkost Looks okay to me, Reviewed-by: Andreas F=E4rber But using this smaller patch will still make inlining pc_new_cpu(), where you are moving it to, bigger diffstat-wise (WIP). Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)