From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2] xen/iommu: fix usage of shared EPT/IOMMU
 page tables on PVH guests
Date: Tue, 10 Mar 2015 12:51:06 +0000
Message-ID: <54FEE8BA.8060505@linaro.org>
References: <1425036812-23536-1-git-send-email-roger.pau@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1YVJdH-0005bA-Qp
	for xen-devel@lists.xenproject.org; Tue, 10 Mar 2015 12:51:35 +0000
Received: by widem10 with SMTP id em10so2681515wid.2
	for <xen-devel@lists.xenproject.org>;
	Tue, 10 Mar 2015 05:51:34 -0700 (PDT)
In-Reply-To: <1425036812-23536-1-git-send-email-roger.pau@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Yang Zhang <yang.z.zhang@intel.com>, Kevin Tian <kevin.tian@intel.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jan Beulich <jbeulich@suse.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

Hi,

On 27/02/15 11:33, Roger Pau Monne wrote:
> diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
> index cc12735..7fcbbb1 100644
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -332,7 +332,8 @@ void iommu_share_p2m_table(struct domain* d)
>  {
>      const struct iommu_ops *ops = iommu_get_ops();
>  
> -    if ( iommu_enabled && is_hvm_domain(d) )
> +    ASSERT( hap_enabled(d) );

This line is breaking compilation on ARM.

Shouldn't it be replaced by iommu_use_hap_pt?

> +    if ( iommu_enabled )


Regards,

-- 
Julien Grall