From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVJdE-0005pD-8f for qemu-devel@nongnu.org; Tue, 10 Mar 2015 08:51:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVJdA-0002Vv-71 for qemu-devel@nongnu.org; Tue, 10 Mar 2015 08:51:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34128 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVJdA-0002Vm-1K for qemu-devel@nongnu.org; Tue, 10 Mar 2015 08:51:28 -0400 Message-ID: <54FEE8CE.60202@suse.de> Date: Tue, 10 Mar 2015 13:51:26 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1425576411-32639-1-git-send-email-ehabkost@redhat.com> <1425576411-32639-2-git-send-email-ehabkost@redhat.com> <54FEDA6F.9000802@suse.de> <20150310124237.GZ3513@thinpad.lan.raisama.net> In-Reply-To: <20150310124237.GZ3513@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: zhugh.fnst@cn.fujitsu.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Paolo Bonzini , Gu Zheng , Igor Mammedov , anshul.makkar@profitbricks.com Am 10.03.2015 um 13:42 schrieb Eduardo Habkost: > On Tue, Mar 10, 2015 at 12:50:07PM +0100, Andreas F=E4rber wrote: >> Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: >>> Instead of passing icc_bridge from the PC initialization code to >>> cpu_x86_create(), make the PC initialization code attach the CPU to >>> icc_bridge. >>> >>> The only difference here is that icc_bridge attachment will now be do= ne >>> after x86_cpu_parse_featurestr() is called. But this shouldn't make a= ny >>> difference, as property setters shouldn't depend on icc_bridge. >>> >>> Signed-off-by: Eduardo Habkost >> >> Looks okay to me, >> >> Reviewed-by: Andreas F=E4rber >> >> But using this smaller patch will still make inlining pc_new_cpu(), >> where you are moving it to, bigger diffstat-wise (WIP). >=20 > I just see this it as a reason to not inline pc_new_cpu(). :) Did you actually read my code? cpu_x86_create() does not allow in-place initialization, in addition to doing the realized=3Dtrue. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)