From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
jbeulich@suse.com, keir@xen.org, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com,
wei.liu2@citrix.com
Cc: elena.ufimtseva@oracle.com, dario.faggioli@citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v4 4/9] sysctl: Make XEN_SYSCTL_numainfo a little more efficient
Date: Tue, 10 Mar 2015 14:34:23 +0000 [thread overview]
Message-ID: <54FF00EF.1060804@citrix.com> (raw)
In-Reply-To: <1425954475-4913-5-git-send-email-boris.ostrovsky@oracle.com>
On 10/03/15 02:27, Boris Ostrovsky wrote:
> Make sysctl NUMA topology query use fewer copies by combining some
> fields into a single structure and copying distances for each node
> in a single copy.
>
> Instead of using max_node_index for passing number of nodes keep this
> value in num_nodes: almost all uses of max_node_index required adding
> or subtracting one to eventually get to number of nodes anyway.
>
> Replace INVALID_NUMAINFO_ID with XEN_INVALID_MEM_SZ and add
> XEN_INVALID_NODE_DIST.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
I have the same concerns with the interface as patch 3, but other comments.
~Andrew
next prev parent reply other threads:[~2015-03-10 14:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 2:27 [PATCH v4 0/9] Display IO topology when PXM data is available (plus some cleanup) Boris Ostrovsky
2015-03-10 2:27 ` [PATCH v4 1/9] numa: __node_distance() should return u8 Boris Ostrovsky
2015-03-10 11:53 ` Andrew Cooper
2015-03-10 13:49 ` Boris Ostrovsky
2015-03-10 2:27 ` [PATCH v4 2/9] pci: Stash device's PXM information in struct pci_dev Boris Ostrovsky
2015-03-13 16:15 ` Jan Beulich
2015-03-10 2:27 ` [PATCH v4 3/9] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient Boris Ostrovsky
2015-03-10 14:29 ` Andrew Cooper
2015-03-10 15:22 ` Boris Ostrovsky
2015-03-11 11:04 ` Ian Campbell
2015-03-11 12:02 ` Boris Ostrovsky
2015-03-11 12:24 ` Ian Campbell
2015-03-13 15:51 ` Jan Beulich
2015-03-10 2:27 ` [PATCH v4 4/9] sysctl: Make XEN_SYSCTL_numainfo " Boris Ostrovsky
2015-03-10 14:34 ` Andrew Cooper [this message]
2015-03-11 11:06 ` Ian Campbell
2015-03-13 15:55 ` Jan Beulich
2015-03-10 2:27 ` [PATCH v4 5/9] sysctl: Add sysctl interface for querying PCI topology Boris Ostrovsky
2015-03-10 14:54 ` Andrew Cooper
2015-03-13 16:03 ` Jan Beulich
2015-03-13 16:35 ` Boris Ostrovsky
2015-03-10 2:27 ` [PATCH v4 6/9] sysctl: Update sysctl version to 0x0000000C Boris Ostrovsky
2015-03-10 2:27 ` [PATCH v4 7/9] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc Boris Ostrovsky
2015-03-10 13:40 ` Dario Faggioli
2015-03-11 11:07 ` Ian Campbell
2015-03-10 2:27 ` [PATCH v4 8/9] libxl/libxc: Move libxl_get_numainfo()'s " Boris Ostrovsky
2015-03-10 13:44 ` Dario Faggioli
2015-03-11 11:08 ` Ian Campbell
2015-03-10 2:27 ` [PATCH v4 9/9] libxl: Add interface for querying hypervisor about PCI topology Boris Ostrovsky
2015-03-10 13:51 ` Dario Faggioli
2015-03-11 11:10 ` Ian Campbell
2015-03-10 8:20 ` [PATCH v4 0/9] Display IO topology when PXM data is available (plus some cleanup) Jan Beulich
2015-03-10 13:39 ` Boris Ostrovsky
2015-03-10 13:47 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FF00EF.1060804@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dario.faggioli@citrix.com \
--cc=elena.ufimtseva@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.