From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVOLQ-0004pX-BW for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:53:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVOLN-0007iJ-2O for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:53:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53663 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVOLM-0007i4-S8 for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:53:24 -0400 Message-ID: <54FF2F93.9050300@suse.de> Date: Tue, 10 Mar 2015 18:53:23 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <20150310183316-mutt-send-email-mst@redhat.com> <54FF2B34.3050106@suse.de> <20150310184052-mutt-send-email-mst@redhat.com> In-Reply-To: <20150310184052-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Marcel Apfelbaum , Paolo Bonzini , qemu-devel@nongnu.org, Alexander Graf Am 10.03.2015 um 18:41 schrieb Michael S. Tsirkin: > On Tue, Mar 10, 2015 at 06:34:44PM +0100, Andreas F=E4rber wrote: >> Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin: >>> Make it safe to include hw/boards.h in exec.c >>> for linux-user configurations. >>> We don't need any of its contents though. >>> >>> Signed-off-by: Michael S. Tsirkin >>> --- >>> >>> Already on my tree as Marcel's patches needed this. >> >> Why? Which patches? >> >> Andreas >=20 > This one: > machine: query dump-guest-core machine property rather than qemu op= ts Let's please find a better way to fix that. hw/boards.h shouldn't be used outside softmmu code. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)