From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVRpp-0006cB-5L for qemu-devel@nongnu.org; Tue, 10 Mar 2015 17:37:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVRpl-00018C-T9 for qemu-devel@nongnu.org; Tue, 10 Mar 2015 17:37:05 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35698 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVRpl-000186-MZ for qemu-devel@nongnu.org; Tue, 10 Mar 2015 17:37:01 -0400 Message-ID: <54FF63F8.5030406@suse.de> Date: Tue, 10 Mar 2015 22:36:56 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1423064635-19045-1-git-send-email-marcel@redhat.com> <1423064635-19045-8-git-send-email-marcel@redhat.com> <54FF2EE0.9010401@suse.de> <20150310222233-mutt-send-email-mst@redhat.com> In-Reply-To: <20150310222233-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, james.hogan@imgtec.com, borntraeger@de.ibm.com, jan.kiszka@siemens.com, Riku Voipio , qemu-devel@nongnu.org, agraf@suse.de, scottwood@freescale.com, cornelia.huck@de.ibm.com, Marcel Apfelbaum , pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: > On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas F=E4rber wrote: >> Hi, >> >> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: >>> Fixes a QEMU crash when passing dump_guest_core parameter in command = line. >> >> Explain that, please? >=20 > Pls note the submission date. It's 1 month late to ask for > basic clarifications. >=20 > I've merged the patches, I'll fix up issues such as prettifying > includes by adding patches on top. No, since the patch is not in qemu.git (it builds!) it is not too late to fix it, nor too late to ask why a patch that introduces a breakage does what it does. (Moving the info from the cover letter into the commit message would've been a good idea, Marcel.) All QEMU patches are supposed to be bisectable. It's our job as maintainers to build-test each. If you do that 1 month later, that's not my fault. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)