From: Ying Xue <ying.xue@windriver.com>
To: David Miller <davem@davemloft.net>, <willemb@google.com>
Cc: <jon.maloy@ericsson.com>, <Paul.Gortmaker@windriver.com>,
<erik.hugne@ericsson.com>, <fengguang.wu@intel.com>,
<netdev@vger.kernel.org>, <tipc-discussion@lists.sourceforge.net>,
<kbuild-all@01.org>
Subject: Re: [PATCH net-next v2] tipc: fix undefined __ipv6_sock_mc_join compile error
Date: Wed, 11 Mar 2015 11:11:37 +0800 [thread overview]
Message-ID: <54FFB269.10009@windriver.com> (raw)
In-Reply-To: <20150310.124742.2005589544373604240.davem@davemloft.net>
On 03/11/2015 12:47 AM, David Miller wrote:
> From: Willem de Bruijn <willemb@google.com>
> Date: Tue, 10 Mar 2015 11:41:03 -0400
>
>> On Tue, Mar 10, 2015 at 4:41 AM, Ying Xue <ying.xue@windriver.com> wrote:
>>> @@ -5,6 +5,7 @@
>>> menuconfig TIPC
>>> tristate "The TIPC Protocol"
>>> depends on INET
>>> + depends on (IPV6 || IPV6=n)
>>
>> Should this be limited to TIPC_MEDIA_UDP?
>
> I think it should.
>
>
My first thought is also same as you. But when the dependency like (IPV6 ||
IPV6=n) is enforced to TIPC_MEDIA_UDP, it doesn't work in the below case:
IPV6=m and TIPC=Y.
In above condition, TIPC_MEDIA_UDP is still set to "Y".
However, if I change the dependency to IPV6=y and IPV6=n, and allow it to limit
TIPC_MEDIA_UDP, TIPC modules can be built successfully in kinds of cases.
Thank for your review! Please wait a moment, and I will fix it in next version.
Regards,
Ying
next prev parent reply other threads:[~2015-03-11 3:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 8:41 [PATCH net-next v2] tipc: fix undefined __ipv6_sock_mc_join compile error Ying Xue
2015-03-10 15:41 ` Willem de Bruijn
2015-03-10 16:47 ` David Miller
2015-03-11 3:11 ` Ying Xue [this message]
2015-03-11 4:05 ` David Miller
2015-03-11 6:24 ` Ying Xue
2015-03-11 3:40 ` Ying Xue
2015-03-10 18:50 ` Sergei Shtylyov
2015-03-11 3:34 ` Ying Xue
2015-03-11 14:34 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FFB269.10009@windriver.com \
--to=ying.xue@windriver.com \
--cc=Paul.Gortmaker@windriver.com \
--cc=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=fengguang.wu@intel.com \
--cc=jon.maloy@ericsson.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.