All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Date: Wed, 11 Mar 2015 14:44:00 +0900	[thread overview]
Message-ID: <54FFD620.1030300@samsung.com> (raw)
In-Reply-To: <54FEB0BD.1070800@free.fr>

Hi,

On 03/10/2015 05:52 PM, Guillaume Gardet wrote:
> 
> 
> Le 28/02/2015 08:59, Minkyu Kang a ?crit :
>> Joonyoung,
>>
>> On 26/02/15 00:22, Guillaume GARDET wrote:
>>> Commit 2e82e9252695a612ab0cbf40fa0c7368515f6506 'Exynos: Clock: Cleanup
>>> soc_get_periph_rate' introduced a bug in I2C config. This patch makes cros_ec
>>> keyboard working again on Samsung Chromebook (snow).
>>>
>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>>> Cc: Akshay Saraswat <akshay.s@samsung.com>
>>> Cc: Minkyu Kang <mk7.kang@samsung.com>
>>> Cc: Joonyoung Shim <jy0922.shim@samsung.com>
>>>
>>> ---
>>>   arch/arm/cpu/armv7/exynos/clock.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c
>>> index c6455c2..7f47d4d 100644
>>> --- a/arch/arm/cpu/armv7/exynos/clock.c
>>> +++ b/arch/arm/cpu/armv7/exynos/clock.c
>>> @@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)
>>>       case PERIPH_ID_I2C6:
>>>       case PERIPH_ID_I2C7:
>>>           src = EXYNOS_SRC_MPLL;
>>> -        div = readl(&clk->div_top0);
>>> -        sub_div = readl(&clk->div_top1);
>>> +        sub_div = readl(&clk->div_top0);
>>> +        div = readl(&clk->div_top1);

Could you keep order of assign statements of div and sub_div variables?

div = readl(&clk->div_top1);
sub_div = readl(&clk->div_top0);

Thanks.

  reply	other threads:[~2015-03-11  5:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 15:22 [U-Boot] [PATCH] Exynos: Clock: Fix exynos5_get_periph_rate for I2C Guillaume GARDET
2015-02-28  7:59 ` Minkyu Kang
2015-03-10  8:52   ` Guillaume Gardet
2015-03-11  5:44     ` Joonyoung Shim [this message]
2015-03-11  9:34       ` [U-Boot] [PATCH V2] " Guillaume GARDET
2015-03-19 17:06         ` Guillaume Gardet
2015-03-24  7:45           ` [U-Boot] [PATCH] " Minkyu Kang
2015-03-25 23:43             ` Simon Glass
2015-03-31  9:07               ` Minkyu Kang
2015-04-06  6:30                 ` Minkyu Kang
2015-03-26  2:12           ` [U-Boot] [PATCH V2] " Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FFD620.1030300@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.