From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC 1/6] drm: Add top level Kconfig option for DRM fbdev emulation Date: Wed, 11 Mar 2015 13:51:02 +0530 Message-ID: <54FFFAEE.3020301@codeaurora.org> References: <1425980493-27533-1-git-send-email-architt@codeaurora.org> <1425980493-27533-2-git-send-email-architt@codeaurora.org> <20150310094756.GE3800@phenom.ffwll.local> <54FEBEF1.5000103@codeaurora.org> <20150310100547.GG3800@phenom.ffwll.local> <54FEC5F1.90208@codeaurora.org> <20150310121702.GO3800@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150310121702.GO3800@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: robdclark@gmail.com, airlied@linux.ie, treding@nvidia.com, p.zabel@pengutronix.de, benjamin.gaignard@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jani Nikula List-Id: linux-arm-msm@vger.kernel.org CgpPbiAwMy8xMC8yMDE1IDA1OjQ3IFBNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IE9uIFR1ZSwg TWFyIDEwLCAyMDE1IGF0IDAzOjUyOjQxUE0gKzA1MzAsIEFyY2hpdCBUYW5lamEgd3JvdGU6Cj4+ IE9uIDAzLzEwLzIwMTUgMDM6MzUgUE0sIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+PiBPbiBUdWUs IE1hciAxMCwgMjAxNSBhdCAwMzoyMjo0OVBNICswNTMwLCBBcmNoaXQgVGFuZWphIHdyb3RlOgo+ Pj4+IE9uIDAzLzEwLzIwMTUgMDM6MTcgUE0sIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+Pj4+IE9u IFR1ZSwgTWFyIDEwLCAyMDE1IGF0IDAzOjExOjI4UE0gKzA1MzAsIEFyY2hpdCBUYW5lamEgd3Jv dGU6Cj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL0tjb25maWcgYi9kcml2ZXJz L2dwdS9kcm0vS2NvbmZpZwo+Pj4+Pj4gaW5kZXggMTUxYTA1MC4uMzhmODNhMCAxMDA2NDQKPj4+ Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9LY29uZmlnCj4+Pj4+PiArKysgYi9kcml2ZXJzL2dw dS9kcm0vS2NvbmZpZwo+Pj4+Pj4gQEAgLTQwLDYgKzQwLDI0IEBAIGNvbmZpZyBEUk1fS01TX0ZC X0hFTFBFUgo+Pj4+Pj4gICAJaGVscAo+Pj4+Pj4gICAJICBGQkRFViBoZWxwZXJzIGZvciBLTVMg ZHJpdmVycy4KPj4+Pj4+Cj4+Pj4+PiArY29uZmlnIERSTV9GQkRFVl9FTVVMQVRJT04KPj4+Pj4+ ICsJYm9vbCAiRW5hYmxlIGxlZ2FjeSBmYmRldiBzdXBwb3J0IGZvciB5b3VyIG1vZGVzZXR0aW5n IGRyaXZlciIKPj4+Pj4+ICsJZGVwZW5kcyBvbiBEUk0KPj4+Pj4+ICsJc2VsZWN0IERSTV9LTVNf SEVMUEVSCj4+Pj4+PiArCXNlbGVjdCBEUk1fS01TX0ZCX0hFTFBFUgo+Pj4+Pj4gKwlzZWxlY3Qg RkJfU1lTX0ZJTExSRUNUCj4+Pj4+PiArCXNlbGVjdCBGQl9TWVNfQ09QWUFSRUEKPj4+Pj4+ICsJ c2VsZWN0IEZCX1NZU19JTUFHRUJMSVQKPj4+Pj4+ICsJc2VsZWN0IEZCX1NZU19GT1BTCj4+Pj4+ PiArCXNlbGVjdCBGQl9DRkJfRklMTFJFQ1QKPj4+Pj4+ICsJc2VsZWN0IEZCX0NGQl9DT1BZQVJF QQo+Pj4+Pj4gKwlzZWxlY3QgRkJfQ0ZCX0lNQUdFQkxJVAo+Pj4+Pj4gKwlkZWZhdWx0IHkKPj4+ Pj4+ICsJaGVscAo+Pj4+Pj4gKwkgIENob29zZSB0aGlzIG9wdGlvbiBpZiB5b3UgaGF2ZSBhIG5l ZWQgZm9yIHRoZSBsZWdhY3kgZmJkZXYKPj4+Pj4+ICsJICBzdXBwb3J0LiBOb3RlIHRoYXQgdGhp cyBzdXBwb3J0IGFsc28gcHJvdmlkZSB0aGUgbGludXggY29uc29sZQo+Pj4+Pj4gKwkgIHN1cHBv cnQgb24gdG9wIG9mIHlvdXIgbW9kZXNldHRpbmcgZHJpdmVyLgo+Pj4+Pgo+Pj4+PiBNYXliZSBj bGFyaWZ5IHRoYXQgZm9yIGxpbnV4IGNvbnNvbGUgc3VwcG9ydCB5b3UgYWxzbyBuZWVkCj4+Pj4+ IENPTkZJR19GUkFNRUJVRkZFUl9DT05TT0xFPyBmYmRldiBhbG9uZSBpc24ndCBlbm91Z2guCj4+ Pj4KPj4+PiBEUk1fS01TX0ZCX0hFTFBFUiBzZWxlY3RzIHRoYXQgZm9yIHVzLCByaWdodD8KPj4+ Cj4+PiBIbSByaWdodCBJJ3ZlIG1pc3NlZCB0aGF0LiBSZW1pbmRzIG1lIHRoYXQgeW91IG5lZWQg b25lIG1vcmUgcGF0Y2ggYXQgdGhlCj4+PiBlbmQgdG8gcmVtb3ZlIGFsbCB0aGUgdmFyaW91cyBz ZWxlY3QgRFJNX0tNU19GQl9IRUxQRVIgZnJvbSBhbGwgZHJtCj4+PiBkcml2ZXJzLiBPdGhlcndp c2UgdGhpcyBrbm9iIGhlcmUgd29uJ3Qgd29yayBieSBkZWZhdWx0IGlmIHlvdSBlLmcuIHNlbGVj dAo+Pj4gcmFkZW9uLiBJbiBnZW5lcmFsIHdlIGNhbid0IG1peCBleHBsaWNpdCBvcHRpb25zIHdp dGggbWVudSBlbnRyaWVzIHdpdGggYQo+Pj4gc2VsZWN0Lgo+Pgo+PiBJIHdhcyB0cnlpbmcgdGhh dCBvdXQuIFJlbW92aW5nIERSTV9LTVNfRkJfSEVMUEVSIGFuZCBoYXZpbmcKPj4gRFJNX0ZCREVW X0VNVUxBVElPTiBkaXNhYmxlZCBicmVha3MgZHJpdmVycyB3aGljaCB1c2UgRkIgc3R1ZmYgaW50 ZXJuYWxseSBpbgo+PiB0aGVpciByZXNwZWN0aXZlIHh5el9mYmRldi5jIGZpbGVzLgo+Cj4gQnV0 IHdpdGggdGhlIHN0dWJiZWQgb3V0IGZ1bmN0aW9ucyB0aGF0IHNob3VsZCB3b3JrLCByaWdodD8g V2h5IGRvZXNuJ3QKPiBpdD8KClRoZXJlIGFyZSBzdGlsbCBjYWxscyB0byBmdW5jdGlvbnMgZnJv bSBmYiBjb3JlIGxpa2UgZmJfc2V0X3N1c3BlbmQgYW5kIApyZWdpc3Rlcl9mcmFtZWJ1ZmZlciB3 aGljaCBhcmVuJ3QgY292ZXJlZCBieSB0aGUgZHJtIGZiIGhlbHBlciBmdW5jdGlvbnMuCgo+Cj4+ IEFyZSB5b3Ugc2F5aW5nIHRoYXQgd2Ugc2hvdWxkIHJlbW92ZSBEUk1fS01TX0ZCX0hFTFBFUiBm b3Igc3VjaCBkcml2ZXJzIGFuZAo+PiByZXBsYWNlIHRoZW0gd2l0aCAnc2VsZWN0IERSTV9GQkRF Vl9FTVVMQVRJT04nPwo+Pgo+PiBBbm90aGVyIG9wdGlvbiB3b3VsZCBiZSB0byBwcm92aWRlICNp ZmRlZiBEUk1fRkJERVZfRU1VTEFUSU9OIHdyYXAtYXJvdW5kcwo+PiBmb3IgZmIgcmVsYXRlZCBm dW5jdGlvbiBjYWxscy9kZWNsYXJhdGlvbnMgaW4gZWFjaCBkcml2ZXIsIHNvbWV0aGluZyB0aGF0 J3MKPj4gYWxyZWFkeSBkb25lIGZvciBpOTE1IGFuZCBtc20gZHJpdmVycy4KPgo+IFRoZSBwcm9i bGVtIHdpdGggdGhlIHBhdGNoIGFzLWlzIHRoZSBtYXNzaXZlIGFtb3VudHMgb2Ygc2VsZWN0cyB0 aGUgRkIKPiBoZWxwZXIgc3RpbGwgaGFzLiBXZSBuZWVkIHRvIGdldCByaWQgb2YgdGhlbSBzbyB0 aGF0IHdoZW4geW91IGRpc2FibGUKPiBmYmRldiBlbXVsYXRpb24geW91IGNhbiBpbmRlZWQgZGlz YWJsZSBmYmNvbiBhbmQgdGhlIGVudGlyZSBmYmRldgo+IHN1YnN5c3RlbS4gSSd2ZSB0aG91Z2h0 IHRoYXQgcmVtb3ZlIHRoZSBoaWRkZW4gc3ltYm9sIERSTV9LTVNfRkJfSEVMUEVSCj4gYW5kIG1v dmluZyBhbGwgdGhlIHNlbGVjdHMgdG8gRFJNX0ZCREVWX0VNVUxBVElPTiBzaG91bGQgd29yayBv dXQ/IElmIHRoYXQKPiBkb2Vzbid0IHdvcmsgd2UgbmVlZCB0byBsb29rIGFnYWluIGhvdyB0byBi ZXR0ZXIgc3R1YiB0aGluZ3Mgb3V0IEkgdGhpbmsuCgpUaGF0J3MgdHJ1ZS4gQWxzbywgYXMgSmFu aSBwb2ludGVkIG91dCwgbWF5YmUgaXQgaXNuJ3QgdGhlIGJlc3QgaWRlYSB0byAKbWFrZSBldmVy eSBrbXMgZHJpdmVyIHNlbGVjdCBEUk1fRkJERVZfRU1VTEFUSU9OPwoKTWF5YmUgdGhlIGRyaXZl cnMgdGhhdCBhcmUgY3VycmVudGx5IGJ1aWx0IHdpdGggZmJkZXYgZW11bGF0aW9uIGJ5IApkZWZh dWx0IGNhbiBhZGQgYSAnZGVwZW5kcyBvbiBEUk1fRkJERVZfRU1VTEFUSU9OJz8gU2luY2UgdGhl IGNvbmZpZyAKZGVmYXVsdHMgdG8geSwgdGhlIGRyaXZlcnMgc2hvdWxkIHJ1biBhcyBpcy4gTGF0 ZXIsIHdlIGNvdWxkIHRha2UgdXAgCmVhY2ggZHJpdmVyIGFuZCBidWlsZCB0aGUgZmIgc3R1ZmYg b25seSB3aGVuIERSTV9GQkRFVl9FTVVMQVRJT04gaXMgc2V0LCAKbGlrZSBob3cgd2UgZG8gZm9y IGk5MTUgYW5kIG1zbT8KCkFyY2hpdAoKLS0gClF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJ bmMuIGlzIGEgbWVtYmVyIG9mIENvZGUgQXVyb3JhIEZvcnVtLAphIExpbnV4IEZvdW5kYXRpb24g Q29sbGFib3JhdGl2ZSBQcm9qZWN0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751607AbbCKIVN (ORCPT ); Wed, 11 Mar 2015 04:21:13 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44349 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbbCKIVJ (ORCPT ); Wed, 11 Mar 2015 04:21:09 -0400 Message-ID: <54FFFAEE.3020301@codeaurora.org> Date: Wed, 11 Mar 2015 13:51:02 +0530 From: Archit Taneja User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: robdclark@gmail.com, airlied@linux.ie, treding@nvidia.com, p.zabel@pengutronix.de, benjamin.gaignard@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jani Nikula Subject: Re: [RFC 1/6] drm: Add top level Kconfig option for DRM fbdev emulation References: <1425980493-27533-1-git-send-email-architt@codeaurora.org> <1425980493-27533-2-git-send-email-architt@codeaurora.org> <20150310094756.GE3800@phenom.ffwll.local> <54FEBEF1.5000103@codeaurora.org> <20150310100547.GG3800@phenom.ffwll.local> <54FEC5F1.90208@codeaurora.org> <20150310121702.GO3800@phenom.ffwll.local> In-Reply-To: <20150310121702.GO3800@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2015 05:47 PM, Daniel Vetter wrote: > On Tue, Mar 10, 2015 at 03:52:41PM +0530, Archit Taneja wrote: >> On 03/10/2015 03:35 PM, Daniel Vetter wrote: >>> On Tue, Mar 10, 2015 at 03:22:49PM +0530, Archit Taneja wrote: >>>> On 03/10/2015 03:17 PM, Daniel Vetter wrote: >>>>> On Tue, Mar 10, 2015 at 03:11:28PM +0530, Archit Taneja wrote: >>>>>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >>>>>> index 151a050..38f83a0 100644 >>>>>> --- a/drivers/gpu/drm/Kconfig >>>>>> +++ b/drivers/gpu/drm/Kconfig >>>>>> @@ -40,6 +40,24 @@ config DRM_KMS_FB_HELPER >>>>>> help >>>>>> FBDEV helpers for KMS drivers. >>>>>> >>>>>> +config DRM_FBDEV_EMULATION >>>>>> + bool "Enable legacy fbdev support for your modesetting driver" >>>>>> + depends on DRM >>>>>> + select DRM_KMS_HELPER >>>>>> + select DRM_KMS_FB_HELPER >>>>>> + select FB_SYS_FILLRECT >>>>>> + select FB_SYS_COPYAREA >>>>>> + select FB_SYS_IMAGEBLIT >>>>>> + select FB_SYS_FOPS >>>>>> + select FB_CFB_FILLRECT >>>>>> + select FB_CFB_COPYAREA >>>>>> + select FB_CFB_IMAGEBLIT >>>>>> + default y >>>>>> + help >>>>>> + Choose this option if you have a need for the legacy fbdev >>>>>> + support. Note that this support also provide the linux console >>>>>> + support on top of your modesetting driver. >>>>> >>>>> Maybe clarify that for linux console support you also need >>>>> CONFIG_FRAMEBUFFER_CONSOLE? fbdev alone isn't enough. >>>> >>>> DRM_KMS_FB_HELPER selects that for us, right? >>> >>> Hm right I've missed that. Reminds me that you need one more patch at the >>> end to remove all the various select DRM_KMS_FB_HELPER from all drm >>> drivers. Otherwise this knob here won't work by default if you e.g. select >>> radeon. In general we can't mix explicit options with menu entries with a >>> select. >> >> I was trying that out. Removing DRM_KMS_FB_HELPER and having >> DRM_FBDEV_EMULATION disabled breaks drivers which use FB stuff internally in >> their respective xyz_fbdev.c files. > > But with the stubbed out functions that should work, right? Why doesn't > it? There are still calls to functions from fb core like fb_set_suspend and register_framebuffer which aren't covered by the drm fb helper functions. > >> Are you saying that we should remove DRM_KMS_FB_HELPER for such drivers and >> replace them with 'select DRM_FBDEV_EMULATION'? >> >> Another option would be to provide #ifdef DRM_FBDEV_EMULATION wrap-arounds >> for fb related function calls/declarations in each driver, something that's >> already done for i915 and msm drivers. > > The problem with the patch as-is the massive amounts of selects the FB > helper still has. We need to get rid of them so that when you disable > fbdev emulation you can indeed disable fbcon and the entire fbdev > subsystem. I've thought that remove the hidden symbol DRM_KMS_FB_HELPER > and moving all the selects to DRM_FBDEV_EMULATION should work out? If that > doesn't work we need to look again how to better stub things out I think. That's true. Also, as Jani pointed out, maybe it isn't the best idea to make every kms driver select DRM_FBDEV_EMULATION? Maybe the drivers that are currently built with fbdev emulation by default can add a 'depends on DRM_FBDEV_EMULATION'? Since the config defaults to y, the drivers should run as is. Later, we could take up each driver and build the fb stuff only when DRM_FBDEV_EMULATION is set, like how we do for i915 and msm? Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project