From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C3FC00528 for ; Tue, 1 Aug 2023 19:14:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232282AbjHATOx (ORCPT ); Tue, 1 Aug 2023 15:14:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231143AbjHATOw (ORCPT ); Tue, 1 Aug 2023 15:14:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9191F1BF0; Tue, 1 Aug 2023 12:14:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F965616A7; Tue, 1 Aug 2023 19:14:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 824A8C433C7; Tue, 1 Aug 2023 19:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690917290; bh=RricL0NBD2SlXPu5D6K3MkV2NfI2Fl9g7qhLIB9lKzs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ZmhBbI6q1rH8SwBWw7Bxp58j12JA0u4tagm4I1spQ4hymiK8n+VSfZn4bnDxGQ5eZ zRTn75Ez47dqoWaZAC/USrqMPfbutYJpA39CcU3FzTLBDCEPbHVCDfqNZ5fHPNyVxi F8p1YiI9Q3oxsyXvYMH07aFZjDm0ZBXeOqRDiHtNkE4yBNMT12zQQypoQw/I2MS8CT 9iVPIC5awUS2tzXak5s1SBNF9fSL0887T4zOFPmsLfd7I13Vvi5Ya20JsFXa6JB2fj XC6b1TtXp+N/aGb6yueKNPuXaAKetcrrl1D/WntkFG00YSO5xydBVrzQ6jyiDJaa1k EpxBXA8mJ1DRg== Message-ID: <54b4d761e5b16ffb798a89c1cea99714.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20230428190226.1304326-1-j.neuschaefer@gmx.net> <20230428190226.1304326-3-j.neuschaefer@gmx.net> <4e0a5db18ed7d37038e67be0f1ddcb08.sboyd@kernel.org> Subject: Re: [PATCH v8 2/2] clk: wpcm450: Add Nuvoton WPCM450 clock/reset controller driver From: Stephen Boyd Cc: Jonathan =?utf-8?q?Neusch=C3=A4fer?= , linux-clk@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, Michael Turquette , Rob Herring , Krzysztof Kozlowski , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Daniel Lezcano , Thomas Gleixner , Philipp Zabel , Wim Van Sebroeck , Guenter Roeck , Christophe JAILLET , Joel Stanley To: Jonathan =?utf-8?q?Neusch=C3=A4fer?= Date: Tue, 01 Aug 2023 12:14:48 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Jonathan Neusch=C3=A4fer (2023-07-22 08:15:43) > On Thu, Jul 20, 2023 at 05:02:15PM -0700, Stephen Boyd wrote: > > Quoting Jonathan Neusch=C3=A4fer (2023-04-28 12:02:26) > > > diff --git a/drivers/clk/clk-wpcm450.c b/drivers/clk/clk-wpcm450.c > [...] > > > +static unsigned long wpcm450_clk_pll_recalc_rate(struct clk_hw *hw, > > > + unsigned long parent= _rate) > > > +{ > > > + struct wpcm450_clk_pll *pll =3D to_wpcm450_clk_pll(hw); [...] >=20 > > > +static const struct wpcm450_pll_data pll_data[] =3D { > > > + { "pll0", { .name =3D "ref" }, REG_PLLCON0, 0 }, > >=20 > > This is new code, please don't use .name. Instead use .fw_name or .inde= x with preference to > > .index first and .hw if the pointer is available in this driver. >=20 > As far as I can see, .fw_name and .index depend on a struct device* > being passed to clk_hw_register, which won't be available unless I > actually convert the driver to a platform driver. You can call of_clk_hw_register(), but a conversion to a platform driver is preferred. >=20 > Not relying on .name would indeed be nice. Cool. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C85FC00528 for ; Tue, 1 Aug 2023 19:15:51 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ZmhBbI6q; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RFlFK3L1Qz30PJ for ; Wed, 2 Aug 2023 05:15:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ZmhBbI6q; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=sboyd@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RFlDF1n8dz2ytX for ; Wed, 2 Aug 2023 05:14:53 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31897616B0; Tue, 1 Aug 2023 19:14:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 824A8C433C7; Tue, 1 Aug 2023 19:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690917290; bh=RricL0NBD2SlXPu5D6K3MkV2NfI2Fl9g7qhLIB9lKzs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ZmhBbI6q1rH8SwBWw7Bxp58j12JA0u4tagm4I1spQ4hymiK8n+VSfZn4bnDxGQ5eZ zRTn75Ez47dqoWaZAC/USrqMPfbutYJpA39CcU3FzTLBDCEPbHVCDfqNZ5fHPNyVxi F8p1YiI9Q3oxsyXvYMH07aFZjDm0ZBXeOqRDiHtNkE4yBNMT12zQQypoQw/I2MS8CT 9iVPIC5awUS2tzXak5s1SBNF9fSL0887T4zOFPmsLfd7I13Vvi5Ya20JsFXa6JB2fj XC6b1TtXp+N/aGb6yueKNPuXaAKetcrrl1D/WntkFG00YSO5xydBVrzQ6jyiDJaa1k EpxBXA8mJ1DRg== Message-ID: <54b4d761e5b16ffb798a89c1cea99714.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20230428190226.1304326-1-j.neuschaefer@gmx.net> <20230428190226.1304326-3-j.neuschaefer@gmx.net> <4e0a5db18ed7d37038e67be0f1ddcb08.sboyd@kernel.org> Subject: Re: [PATCH v8 2/2] clk: wpcm450: Add Nuvoton WPCM450 clock/reset controller driver From: Stephen Boyd To: Jonathan =?utf-8?q?Neusch=C3=A4fer?= Date: Tue, 01 Aug 2023 12:14:48 -0700 User-Agent: alot/0.10 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomer Maimon , Michael Turquette , Tali Perry , linux-clk@vger.kernel.org, Benjamin Fair , openbmc@lists.ozlabs.org, Daniel Lezcano , Joel Stanley , Guenter Roeck , devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, Jonathan =?utf-8?q?Neusch=C3=A4fer?= , Rob Herring , Christophe JAILLET , Thomas Gleixner , Wim Van Sebroeck , Avi Fishman , Patrick Venture , linux-kernel@vger.kernel.org, Philipp Zabel , Krzysztof Kozlowski Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Quoting Jonathan Neusch=C3=A4fer (2023-07-22 08:15:43) > On Thu, Jul 20, 2023 at 05:02:15PM -0700, Stephen Boyd wrote: > > Quoting Jonathan Neusch=C3=A4fer (2023-04-28 12:02:26) > > > diff --git a/drivers/clk/clk-wpcm450.c b/drivers/clk/clk-wpcm450.c > [...] > > > +static unsigned long wpcm450_clk_pll_recalc_rate(struct clk_hw *hw, > > > + unsigned long parent= _rate) > > > +{ > > > + struct wpcm450_clk_pll *pll =3D to_wpcm450_clk_pll(hw); [...] >=20 > > > +static const struct wpcm450_pll_data pll_data[] =3D { > > > + { "pll0", { .name =3D "ref" }, REG_PLLCON0, 0 }, > >=20 > > This is new code, please don't use .name. Instead use .fw_name or .inde= x with preference to > > .index first and .hw if the pointer is available in this driver. >=20 > As far as I can see, .fw_name and .index depend on a struct device* > being passed to clk_hw_register, which won't be available unless I > actually convert the driver to a platform driver. You can call of_clk_hw_register(), but a conversion to a platform driver is preferred. >=20 > Not relying on .name would indeed be nice. Cool.