From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1C75C4345F for ; Tue, 30 Apr 2024 16:50:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA484112D04; Tue, 30 Apr 2024 16:50:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="SjRUCGc6"; dkim-atps=neutral Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id 14B38112D03 for ; Tue, 30 Apr 2024 16:50:30 +0000 (UTC) Message-ID: <54be9c58-3e14-42c1-8fe4-4b03b630d1ac@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714495828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lFJZeubY0pH8XJB+NDsWHv5pVnm39sgZ/JqOBa9DJ8o=; b=SjRUCGc6H5+LA2XHJrXgHFE0vv/DjJUP0keVPI9OKuB6DqHmWMChS69yqn7wJmwcfxxuWN RQLJeBrsglP16SZJGsHEZSf+SmhZ63a2k4/kqu86Uafki6vsXRg+uRClV22PRQiZtI7wLd jDVP8x2s8YvWFmuREo1yInmy7J9Pgjo= Date: Wed, 1 May 2024 00:50:20 +0800 MIME-Version: 1.0 Subject: Re: [v1,2/3] drm/panel: ili9341: Respect deferred probe To: Andy Shevchenko , Neil Armstrong , Randy Dunlap , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter References: <20240425142706.2440113-3-andriy.shevchenko@linux.intel.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <20240425142706.2440113-3-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 2024/4/25 22:26, Andy Shevchenko wrote: > GPIO controller might not be available when driver is being probed. > There are plenty of reasons why, one of which is deferred probe. > > Since GPIOs are optional, return any error code we got to the upper > layer, including deferred probe. With that in mind, use dev_err_probe() > in order to avoid spamming the logs. > > Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") > Signed-off-by: Andy Shevchenko > Reviewed-by: Neil Armstrong Reviewed-by: Sui Jingfeng -- Best regards, Sui