Hi, Mac: On Sat, 2024-06-08 at 20:01 +0800, mac.shen wrote: > Changes in v3: > - refine the function to get system time > - refine the flow to do HDCP with content type and > protection value which set by user space > - refine the flow to update content protection > - refine the flow to do HDCP2.x authentication > per suggestion from the previous thread: > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek__;!!CTRNKA9wMg0ARbw!md6xUiYN88D2YmETs8FQgaExM2zH8S1SmAEU9GRchwpNsXOyDFul3ziVKhRpCJaj8Rcn-gvM-801runjwA$ > /patch/20240205055055.25340-3-mac.shen@mediatek.com/ > > Signed-off-by: mac.shen > --- [snip] > + > +static int dp_tx_hdcp2x_write_lc_init(struct mtk_hdcp_info *hdcp_info) > +{ > + struct mtk_dp *mtk_dp = container_of(hdcp_info, struct mtk_dp, hdcp_info); > + ssize_t ret; > + > + dev_dbg(mtk_dp->dev, "[HDCP2.X] HDCP_2_2_LC_INIT\n"); > + > + ret = drm_dp_dpcd_write(&mtk_dp->aux, DP_HDCP_2_2_LC_INIT_OFFSET, > + hdcp_info->hdcp2_info.hdcp_tx.lc_init.r_n, HDCP_2_2_RN_LEN); > + if (ret < 0) > + return ret; > + > + return 0; This function is called only by dp_tx_hdcp2x_locality_check() and this function just does one thing. So merge this function into dp_tx_hdcp2x_locality_check(). Regards, CK > +} > +