All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org, Marcus Hoffmann <bubu@bubu1.eu>
Subject: Re: [Buildroot] [PATCH 1/1] package/python-pydantic-core: bump to version 2.39.0
Date: Wed, 17 Sep 2025 21:30:41 +0200	[thread overview]
Message-ID: <54f8a68618b7b3c4889a0f902706b84c@free.fr> (raw)
In-Reply-To: <CADvTj4p4s9jbx=hVBHhPJQ5yfqQmrL=1XTxJbdkJLRbQr4cO3Q@mail.gmail.com>

Hi James,

On 17/09/2025 20:24, James Hilliard wrote:
> On Wed, Sep 17, 2025 at 11:52 AM Julien Olivain <ju.o@free.fr> wrote:
>> 
>> Hi James,
>> 
>> On 17/09/2025 19:29, James Hilliard wrote:
>> > On Wed, Sep 17, 2025 at 11:19 AM Julien Olivain <ju.o@free.fr> wrote:
>> >>
>> >> Hi James,
>> >>
>> >> Thanks for the patch.
>> >>
>> >> On 16/09/2025 02:30, James Hilliard wrote:
>> >> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>> >> > ---
>> >> [...]
>> >> > diff --git a/package/python-pydantic-core/python-pydantic-core.mk
>> >> > b/package/python-pydantic-core/python-pydantic-core.mk
>> >> > index 5085b906d5..7342711b2a 100644
>> >> > --- a/package/python-pydantic-core/python-pydantic-core.mk
>> >> > +++ b/package/python-pydantic-core/python-pydantic-core.mk
>> >> > @@ -6,10 +6,10 @@
>> >> >
>> >> >  # python-pydantic pins an exact version of pydantic-core in
>> >> > pyproject.toml,
>> >> >  # make sure to sync pydantic-core to this version when updating
>> >> > pydantic
>> >> > -PYTHON_PYDANTIC_CORE_VERSION = 2.33.2
>> >> > +PYTHON_PYDANTIC_CORE_VERSION = 2.39.0
>> >>
>> >> This new version breaks the runtime tests. See:
>> >> https://gitlab.com/jolivain/buildroot/-/pipelines/2045487786
>> >>
>> >> Could you have a look please?
>> >>
>> >> It is likely a missing runtime dependency. I did not applied
>> >> the python-pydantic bump from:
>> >> https://patchwork.ozlabs.org/project/buildroot/patch/20250916003319.2510050-1-james.hilliard1@gmail.com/
>> >>
>> >> I'll retest both bumps at the same time.
>> >
>> > Yeah, based on the error I think applying both at the same time should
>> > fix it.
>> 
>> I don't think so. I tested with both patches applied on top of the 
>> rest
>> of your python updates. See:
>> https://gitlab.com/jolivain/buildroot/-/commits/bump-tests.package.test_python_pydantic
>> 
>> So I think there is really some new runtime dependency missing.
> 
> I think I see the issue, the latest version of pydantic specifies an 
> older
> version(our current version) of pydantic-core for compatibility:
> https://github.com/pydantic/pydantic/blob/v2.11.9/pyproject.toml#L49
> 
> So I'll drop the pydantic-core bump, you should be able to merge the
> pydantic bump by itself.

I confirm the pydantic bump alone works fine:
https://gitlab.com/jolivain/buildroot/-/pipelines/2045697266

So I'll apply it and ignore pydantic-core for the the moment.

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2025-09-17 19:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16  0:30 [Buildroot] [PATCH 1/1] package/python-pydantic-core: bump to version 2.39.0 James Hilliard
2025-09-17 17:19 ` Julien Olivain via buildroot
2025-09-17 17:29   ` James Hilliard
2025-09-17 17:52     ` Julien Olivain via buildroot
2025-09-17 18:24       ` James Hilliard
2025-09-17 19:30         ` Julien Olivain via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54f8a68618b7b3c4889a0f902706b84c@free.fr \
    --to=buildroot@buildroot.org \
    --cc=bubu@bubu1.eu \
    --cc=james.hilliard1@gmail.com \
    --cc=ju.o@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.