From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2] xen/iommu: fix usage of shared EPT/IOMMU page tables on PVH guests Date: Wed, 11 Mar 2015 10:52:09 +0000 Message-ID: <55001E59.7080307@linaro.org> References: <1425036812-23536-1-git-send-email-roger.pau@citrix.com> <54FEE8BA.8060505@linaro.org> <54FEFA5102000078000680F7@mail.emea.novell.com> <54FEEF33.7010201@linaro.org> <54FF012E02000078000681AF@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YVeFK-0007uY-24 for xen-devel@lists.xenproject.org; Wed, 11 Mar 2015 10:52:14 +0000 Received: by widex7 with SMTP id ex7so37107600wid.3 for ; Wed, 11 Mar 2015 03:52:12 -0700 (PDT) In-Reply-To: <54FF012E02000078000681AF@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Roger Pau Monne Cc: Yang Zhang , xen-devel@lists.xenproject.org, Kevin Tian , Aravind Gopalakrishnan , Suravee Suthikulpanit List-Id: xen-devel@lists.xenproject.org Hi Jan, On 10/03/2015 13:35, Jan Beulich wrote: > Ah, right, I mixed this up with iommu_hap_pt_share. Roger - looks > like this could indeed be replaced by > > if ( iommu_enabled && iommu_use_hap_pt(d) ) > ops->share_p2m(d); > > and the corresponding check in VT-d and AMD Vi code could then > also be dropped. Royger seems to be away. As it break ARM support I will send a patch today. Regards, -- Julien Grall