From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Mark Brown <broonie@kernel.org>
Cc: Doug Anderson <dianders@chromium.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] regulator: Only enable disabled regulators on resume
Date: Wed, 11 Mar 2015 12:00:53 +0100 [thread overview]
Message-ID: <55002065.9070206@collabora.co.uk> (raw)
In-Reply-To: <20150311105744.GX28806@sirena.org.uk>
On 03/11/2015 11:57 AM, Mark Brown wrote:
> On Mon, Mar 09, 2015 at 08:40:20AM +0100, Javier Martinez Canillas wrote:
>> On 03/08/2015 08:38 PM, Mark Brown wrote:
>> > You mean _do_enable(), not _enable() here. It's not really a leftover
>
>> No, I meant _enable() here. What I said is that _enable() is checking
>> if -EINVAL was returned by _is_enabled():
>
> Then we have an abstraction problem if we're trying to do things in
> plain _enable() - _do_enable() is supposed to be hiding all this stuff.
>
Agreed.
Best regards,
Javier
next prev parent reply other threads:[~2015-03-11 11:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 20:40 [PATCH 1/1] regulator: Only enable disabled regulators on resume Javier Martinez Canillas
2015-03-03 17:24 ` Doug Anderson
2015-03-03 19:05 ` Javier Martinez Canillas
2015-03-04 13:45 ` Javier Martinez Canillas
2015-03-08 19:38 ` Mark Brown
2015-03-09 7:40 ` Javier Martinez Canillas
2015-03-11 10:57 ` Mark Brown
2015-03-11 11:00 ` Javier Martinez Canillas [this message]
2015-03-08 19:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55002065.9070206@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.