From: Grygorii Strashko <grygorii.strashko@ti.com>
To: balbi@ti.com
Cc: wsa@the-dreams.de, Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: omap: implement bus recovery
Date: Wed, 11 Mar 2015 15:47:53 +0200 [thread overview]
Message-ID: <55004789.7080706@ti.com> (raw)
In-Reply-To: <20150311015004.GB21726@saruman.tx.rr.com>
Hi Felipe,
On 03/11/2015 03:50 AM, Felipe Balbi wrote:
> On Mon, Mar 09, 2015 at 11:39:17AM -0500, Felipe Balbi wrote:
>> On Thu, Feb 19, 2015 at 12:06:49PM -0600, Felipe Balbi wrote:
>>> If either SCL or SDA are stuck low, we need to
>>> recover the bus using the procedure described
>>> on section 3.1.16 of the I2C specification.
>>>
>>> Note that we're trying to implement the procedure
>>> exactly as described by that section. First we
>>> check which line is stuck low, then implement
>>> one or the other procedure. If SDA recovery procedure
>>> fails, we reset our IP in an attempt to make it work.
>>>
>>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>>> ---
>>>
>>> Tested with AM437x IDK, AM437x SK, BeagleBoneBlack and Beagle X15 with
>>> 1000 iterations of i2cdetect on all available buses.
>>>
>>> That said, I couldn't get any device to hold the bus busy so I could
>>> see this working. If anybody has any good way of forcing a condition
>>> so that we need bus recovery, I'd be glad to look at.
>>
>> ping
>
> any comments here ?? Anybody at all ????
>
I think the I2C bus recovery infrastructure should be used here ;)
As I did there https://lkml.org/lkml/2014/12/1/397, but
there are no comments too :(
regards,
-grygorii
next prev parent reply other threads:[~2015-03-11 13:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 18:06 [PATCH] i2c: omap: implement bus recovery Felipe Balbi
[not found] ` <1424369209-26735-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2015-02-19 18:09 ` Felipe Balbi
2015-03-09 16:39 ` Felipe Balbi
[not found] ` <20150309163917.GI3739-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-03-11 1:50 ` Felipe Balbi
2015-03-11 13:47 ` Grygorii Strashko [this message]
2015-03-11 15:22 ` Wolfram Sang
2015-04-10 21:41 ` Wolfram Sang
2015-05-06 16:44 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2015-05-06 16:50 Felipe Balbi
2015-05-06 16:50 ` Felipe Balbi
2015-05-12 19:19 ` Wolfram Sang
2015-05-12 19:19 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55004789.7080706@ti.com \
--to=grygorii.strashko@ti.com \
--cc=balbi@ti.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.