From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34123)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YVhEK-0001nM-Ui
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 10:03:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YVhEA-00058J-I4
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 10:03:24 -0400
Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:42796)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YVhEA-000583-6P
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 10:03:14 -0400
Received: by widex7 with SMTP id ex7so12042888wid.1
	for <qemu-devel@nongnu.org>; Wed, 11 Mar 2015 07:03:13 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <55004B1E.2010702@redhat.com>
Date: Wed, 11 Mar 2015 15:03:10 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1426081233-7801-1-git-send-email-mst@redhat.com>
	<20150311144311-mutt-send-email-mst@redhat.com>
In-Reply-To: <20150311144311-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] virtio-scsi: clean out duplicate cdb
	field
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Fam Zheng <famz@redhat.com>, Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>



On 11/03/2015 14:43, Michael S. Tsirkin wrote:
>          struct {
>              VirtIOSCSICmdReq  cmd;
> -            uint8_t           cdb[];
>          } QEMU_PACKED;

Just:

    VirtIOSCSICmdReq cmd;

without the wrapping struct.

With this change series

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

>          VirtIOSCSICtrlTMFReq  tmf;
>          VirtIOSCSICtrlANReq   an;
>      } req;
>  } VirtIOSCSIReq;
>  
> -QEMU_BUILD_BUG_ON(offsetof(VirtIOSCSIReq, req.cdb) !=
> -                  offsetof(VirtIOSCSIReq, req.cmd) + sizeof(VirtIOSCSICmdReq));
> -