All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Eryu Guan <eguan@redhat.com>, fstests@vger.kernel.org
Subject: Re: [PATCH 2/4] generic/027: discard mkdir error message
Date: Wed, 11 Mar 2015 10:08:22 -0400	[thread overview]
Message-ID: <55004C56.9040004@sandeen.net> (raw)
In-Reply-To: <1426072534-12246-3-git-send-email-eguan@redhat.com>

On 3/11/15 7:15 AM, Eryu Guan wrote:
> mkdir fails due to ENOSPC occasionally and will fail the whole test.
> Redirect stdout and stderr to /dev/null.
> 
> Also fix the code style in _cleanup to use single tab.
> 
> Signed-off-by: Eryu Guan <eguan@redhat.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  tests/generic/027 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/generic/027 b/tests/generic/027
> index 8dab117..d2e59d6 100755
> --- a/tests/generic/027
> +++ b/tests/generic/027
> @@ -36,8 +36,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>  
>  _cleanup()
>  {
> -    cd /
> -    rm -f $tmp.*
> +	cd /
> +	rm -f $tmp.*
>  }
>  
>  create_file()
> @@ -46,7 +46,7 @@ create_file()
>  	local direct=$2
>  	local i=0
>  
> -	mkdir -p $dir
> +	mkdir -p $dir >/dev/null 2>&1
>  	while $XFS_IO_PROG -f $direct -c "pwrite 0 1k" $dir/file_$i >/dev/null 2>&1; do
>  		let i=$i+1
>  	done
> 


  reply	other threads:[~2015-03-11 14:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 11:15 [PATCH 0/4] some random small fixes Eryu Guan
2015-03-11 11:15 ` [PATCH 1/4] new: fix template for new case to use a single tab not four spaces Eryu Guan
2015-03-11 13:59   ` Eric Sandeen
2015-03-11 11:15 ` [PATCH 2/4] generic/027: discard mkdir error message Eryu Guan
2015-03-11 14:08   ` Eric Sandeen [this message]
2015-03-11 11:15 ` [PATCH 3/4] common: append -d option to XFS_COPY_PROG when testing v5 xfs Eryu Guan
2015-03-11 14:48   ` Eric Sandeen
2015-03-11 14:52     ` Eric Sandeen
2015-03-12  5:57     ` Eryu Guan
2015-03-11 11:15 ` [PATCH 4/4] xfs/073: be quiet about mouting with nouuid option Eryu Guan
2015-03-11 14:51   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55004C56.9040004@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.