From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36970)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YVhOs-0001XC-T8
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 10:14:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YVhOp-0000u4-DC
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 10:14:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45493)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YVhOp-0000tl-62
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 10:14:15 -0400
Message-ID: <55004DAC.6030608@redhat.com>
Date: Wed, 11 Mar 2015 15:14:04 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150311151331-mutt-send-email-mst@redhat.com>
In-Reply-To: <20150311151331-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-scsi: remove empty wrapper for cmd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, Ming Lei <ming.lei@canonical.com>, Fam Zheng <famz@redhat.com>



On 11/03/2015 15:13, Michael S. Tsirkin wrote:
> The anonymous struct only has a single field now, drop the wrapper
> structure.
> 
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  include/hw/virtio/virtio-scsi.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index e3f27a6..f93b57d 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -134,9 +134,7 @@ typedef struct VirtIOSCSIReq {
>          VirtIOSCSIEvent       event;
>      } resp;
>      union {
> -        struct {
> -            VirtIOSCSICmdReq  cmd;
> -        } QEMU_PACKED;
> +        VirtIOSCSICmdReq      cmd;
>          VirtIOSCSICtrlTMFReq  tmf;
>          VirtIOSCSICtrlANReq   an;
>      } req;
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>