All of lore.kernel.org
 help / color / mirror / Atom feed
From: Murali Karicheri <m-karicheri2@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Rob Herring <robherring2@gmail.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Suravee Suthikulanit <Suravee.Suthikulpanit@amd.com>,
	Will Deacon <will.deacon@arm.com>, Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH] pci: of : fix BUG: unable to handle kernel
Date: Wed, 11 Mar 2015 11:28:15 -0400	[thread overview]
Message-ID: <55005F0F.5080302@ti.com> (raw)
In-Reply-To: <20150311124911.GA8656@n2100.arm.linux.org.uk>

On 03/11/2015 08:49 AM, Russell King - ARM Linux wrote:
> On Wed, Mar 11, 2015 at 07:35:45AM -0500, Rob Herring wrote:
>> On Tue, Mar 10, 2015 at 10:25 AM, Murali Karicheri<m-karicheri2@ti.com>  wrote:
>>> On some platforms such as that based on x86, ia64 etc, root bus is
>>> created with parent node passed in as NULL to pci_create_root_bus().
>>> On these platforms, the patch series "PCI: get DMA configuration from
>>> parent device" when applied causes kernel crash. So add a check for this
>>> in of_pci_dma_configure()
>>
>> Wouldn't these arches have OF disabled and call an empty function?
>> Regardless, we still need this.
>>
>>> Signed-off-by: Murali Karicheri<m-karicheri2@ti.com>
>>
>> I'm assuming Bjorn will apply this.
>>
>> Acked-by: Rob Herring<robh@kernel.org>
>
> It might be an idea to read the subject line...
>
> "fix BUG: unable to handle kernel"
Russell,

I will fix the subject as "fix BUG: unable to handle kernel NULL 
pointer" and re-send.

Thanks

Murali
>
> which is meaningless.  It needs a much better subject line before it can
> be committed.
>


-- 
Murali Karicheri
Linux Kernel, Texas Instruments

  reply	other threads:[~2015-03-11 15:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 15:25 [PATCH] pci: of : fix BUG: unable to handle kernel Murali Karicheri
2015-03-10 15:25 ` Murali Karicheri
2015-03-11 12:35 ` Rob Herring
2015-03-11 12:35   ` Rob Herring
2015-03-11 12:49   ` Russell King - ARM Linux
2015-03-11 15:28     ` Murali Karicheri [this message]
2015-03-11 15:59       ` Rob Herring
2015-03-11 16:37         ` Murali Karicheri
2015-03-11 20:27         ` Murali Karicheri
2015-03-11 15:25   ` Murali Karicheri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55005F0F.5080302@ti.com \
    --to=m-karicheri2@ti.com \
    --cc=Suravee.Suthikulpanit@amd.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.