From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751524AbbCKPzn (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Mar 2015 11:55:43 -0400
Received: from mga09.intel.com ([134.134.136.24]:57619 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750707AbbCKPzm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Mar 2015 11:55:42 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,382,1422950400"; 
   d="scan'208";a="465821600"
Message-ID: <55006579.4000402@intel.com>
Date: Wed, 11 Mar 2015 17:55:37 +0200
From: Adrian Hunter <adrian.hunter@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
CC: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@gmail.com>, Paul Mackerras <paulus@samba.org>,
        Stephane Eranian <eranian@google.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH V5 00/25] perf tools: Introduce an abstraction for Instruction
 Tracing
References: <1425762394-29799-1-git-send-email-adrian.hunter@intel.com>
In-Reply-To: <1425762394-29799-1-git-send-email-adrian.hunter@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/03/2015 11:06 p.m., Adrian Hunter wrote:
> Hi
>
> Here is V5 of some more preparatory patches for Intel PT
> that introduce an abstraction for Instruction tracing.
>
> The Intel PT driver is not yet in tip.
>
> Peter, could we please have Alex's 14 patches applied to
> tip?

Peter, I know you are really busy, but it would be helpful to know
what you plan to do?

>
> The master branch of the tree:
>
> 	git://git.infradead.org/users/ahunter/linux-perf.git
>
> contains these patches plus Intel PT and BTS and the kernel driver.
>
> Arnaldo, I have re-based on tip because of the conflict
> with your ordered-events changes. I will have a closer look
> at that next week.

I took a closer look and resolved the conflict by introducing:

static int perf_session__deliver_ordered_event(struct ordered_events *oe,
                                                struct ordered_event *event,
                                                struct perf_sample *sample)
{
         struct perf_session *session =
                         container_of(oe, struct perf_session, ordered_events);

         return perf_session__deliver_event(session, event->event, sample,
                                            oe->tool, event->file_offset);
}

I will send another revision of the patch set, but I am also
considered renaming everything from "itrace" to something more
generic. Possibly "auxtrace" or "hwtrace". Any preferences?