From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44865)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1YVmtJ-0002ae-FJ
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 16:06:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1YVmtD-0001ox-O9
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 16:06:05 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:54038)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1YVmtD-0001oa-Dz
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 16:05:59 -0400
Message-ID: <5500A025.4050305@msgid.tls.msk.ru>
Date: Wed, 11 Mar 2015 23:05:57 +0300
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <cover.1425678142.git.mjt@msgid.tls.msk.ru>
	<b98f675750ef0535cab41225240db1657fc2fe00.1425678142.git.mjt@msgid.tls.msk.ru>
	<54FB6199.6030306@redhat.com> <54FB775D.6080608@msgid.tls.msk.ru>
	<877fur4fq8.fsf@linux.vnet.ibm.com>
	<54FE71C2.2080609@msgid.tls.msk.ru>
	<87egowrbqm.fsf@linux.vnet.ibm.com>
	<54FFD96A.6040205@msgid.tls.msk.ru>
	<8761a7rkf7.fsf@linux.vnet.ibm.com>
In-Reply-To: <8761a7rkf7.fsf@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

11.03.2015 11:46, Aneesh Kumar K.V wrote:
[]
> ... Rather than saying
> 
>    "Oh well.  I've no idea how this code has been accepted.
>    It is absolute crap."
> 
> it would be nice if we take up specific issues, w.r.t the os/cpu
> combination where we are running into issues, we may be able to fix this
> easily.

The specific issues were outlined and partially fixed by the v3
patchset.  This is, for example, the way v9fs_request() is called
with arguments for v9fs_marshal function, which are ignored and
new arguments are constructed inside _request.  That's what I
refer to when saying it is a complete crap.  Do you not agree? :)

[]
> Note: At this point i haven't picked any of the patches posted, so if
> you have anything specific you want me to take up, please repost then
> with correct version number (v1, v2...)

I sent a v3 (last) with correct version number, it has just 3 (rather
big) patches: http://thread.gmane.org/gmane.comp.emulators.qemu/324157 .

Thanks,

/mjt