From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVraY-0001xu-5Q for qemu-devel@nongnu.org; Wed, 11 Mar 2015 21:07:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVraU-0000FZ-Ni for qemu-devel@nongnu.org; Wed, 11 Mar 2015 21:07:02 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:52607) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVraT-0000E8-UZ for qemu-devel@nongnu.org; Wed, 11 Mar 2015 21:06:58 -0400 Message-ID: <5500E6A5.7010102@huawei.com> Date: Thu, 12 Mar 2015 09:06:45 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1425883543-8852-1-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1425883543-8852-1-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: hangaohuai@huawei.com, quintela@redhat.com, armbru@redhat.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com, amit.shah@redhat.com, dgilbert@redhat.com ping... Should this series be merged in 2.3 version? I noticed that 3.17 is hardfreeze time. On 2015/3/9 14:45, zhanghailiang wrote: > Hi, > > This series converts open-coded 'str' type to enum type for 'status'. > > This conversion will be more convenient for future extensibility. > Actually, I will add a MIG_STATE_COLO state for COLO, and i also > saw Dave added MIG_STATE_POSTCOPY_ACTIVE for postcopy. > > Patch 1 and 2 are preparation for the conversion, patch 3 completes the conversion. > Besides, i add a additional patch (patch 4) to expose 'cancelling' to user, > it will influence libvirt side. And i have CC libvirt development. > > One more thing, i have to replace MIG_STATE_ERROR with MIGRATION_STATUS_FAILED, > and it begin from 0, not its original -1. I think it has no side effect. > > Please review. > > v4: > - Rename _ERROR to _FAILED in patch 1 instead of patch 4 (Eric) > - Add Reviewd-by for patch 2 and 4 > - Fix some grammar in commit message of patch 4 (Eric) > > v3: > - Use longer name for Migration status macro. (Eric Blake) > - Rename internal-only typename 'MigrationStatus' (Eric, Dave, Markus) > - Expose 'cancelling' state (Eric Blake) > > v2: > - Remove '(since xyz)' strings. (Eric Blake) > > Thanks for their comments. ;) > > zhanghailiang (4): > migration: Rename abbreviated macro MIG_STATE_* to > MIGRATION_STATUS_* > hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus' > migration: Convert 'status' of MigrationInfo to use an enum type > migration: Expose 'cancelling' status to user > > hmp.c | 15 ++++---- > migration/migration.c | 95 ++++++++++++++++++++++++--------------------------- > qapi-schema.json | 34 +++++++++++++++--- > 3 files changed, 81 insertions(+), 63 deletions(-) >