All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lian Minghuan-B31939 <B31939@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] pci/layerscape: move pcie_layerscape.h out of arm include
Date: Thu, 12 Mar 2015 10:21:34 +0800	[thread overview]
Message-ID: <5500F82E.2060004@freescale.com> (raw)
In-Reply-To: <20150311142214.GK32541@bill-the-cat>

Hi Tom,

Thanks for your comments.
I will use the common name and remove unnecessary file pcie_layerscape.h

Thanks,
Minghuan


On 2015?03?11? 22:22, Tom Rini wrote:
> On Wed, Mar 11, 2015 at 07:09:33PM +0800, Minghuan Lian wrote:
>
>> The patch moves pcie_layerscape.h out of arm include to top
>> level include folder so that it can be shared on other Socs.
>>
>> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> OK, I see a problem:
>
>> diff --git a/arch/arm/include/asm/pcie_layerscape.h b/arch/arm/include/asm/pcie_layerscape.h
>> deleted file mode 100644
>> index fb08578..0000000
>> --- a/arch/arm/include/asm/pcie_layerscape.h
>> +++ /dev/null
>> @@ -1,13 +0,0 @@
>> -/*
>> - * Copyright 2014 Freescale Semiconductor, Inc.
>> - *
>> - * SPDX-License-Identifier:	GPL-2.0+
>> - */
>> -
>> -#ifndef __PCIE_LAYERSCAPE_H_
>> -#define __PCIE_LAYERSCAPE_H_
>> -
>> -void pci_init_board(void);
> This is already in <common.h>
>
>> -void ft_pcie_setup(void *blob, bd_t *bd);
> This belongs in <fdt_support.h> near other similar functions and frankly
> might be better done as ft_pci_setup(blob, bd) which already exists.  Or
> do we have both ft_pci_setup and ft_pcie_setup existing at the same
> time?
>

      reply	other threads:[~2015-03-12  2:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 11:09 [U-Boot] [PATCH 1/2] pci/layerscape: move pcie_layerscape.h out of arm include Minghuan Lian
2015-03-11 11:09 ` [U-Boot] [PATCH 2/2] pci/layerscape: fix link and class issues to support ls2085a Minghuan Lian
2015-03-11 14:22 ` [U-Boot] [PATCH 1/2] pci/layerscape: move pcie_layerscape.h out of arm include Tom Rini
2015-03-12  2:21   ` Lian Minghuan-B31939 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5500F82E.2060004@freescale.com \
    --to=b31939@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.