From: Ying Xue <ying.xue@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: <jon.maloy@ericsson.com>, <Paul.Gortmaker@windriver.com>,
<erik.hugne@ericsson.com>, <fengguang.wu@intel.com>,
<netdev@vger.kernel.org>, <willemb@google.com>,
<tipc-discussion@lists.sourceforge.net>, <kbuild-all@01.org>
Subject: Re: [PATCH net-next v3] tipc: fix undefined __ipv6_sock_mc_join compile error
Date: Thu, 12 Mar 2015 11:35:04 +0800 [thread overview]
Message-ID: <55010968.5090606@windriver.com> (raw)
In-Reply-To: <20150311.175954.948622401089738977.davem@davemloft.net>
On 03/12/2015 05:59 AM, David Miller wrote:
> From: Ying Xue <ying.xue@windriver.com>
> Date: Wed, 11 Mar 2015 15:51:13 +0800
>
>> diff --git a/net/tipc/Kconfig b/net/tipc/Kconfig
>> index c25a3a1..5bb8fc9 100644
>> --- a/net/tipc/Kconfig
>> +++ b/net/tipc/Kconfig
>> @@ -29,6 +29,7 @@ config TIPC_MEDIA_IB
>> config TIPC_MEDIA_UDP
>> bool "IP/UDP media type support"
>> depends on TIPC
>> + depends on (IPV6=y || IPV6=n)
>> select NET_UDP_TUNNEL
>> help
>> Saying Y here will enable support for running TIPC over IP/UDP
>
> This really is not what you want.
>
> You want to enable TIPC_MEDIA_UDP if IPV6 is "compatible" with TIPC,
> what you're using here is a sledgehammer.
>
> I would really suggest breaking this facility out into it's own
> module, then you can mark it tristate and do this correctly.
>
>
Thank you for the review. OK, I will change the code again following your
suggestions.
Regards,
Ying
prev parent reply other threads:[~2015-03-12 3:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 7:51 [PATCH net-next v3] tipc: fix undefined __ipv6_sock_mc_join compile error Ying Xue
2015-03-11 21:59 ` David Miller
2015-03-12 3:35 ` Ying Xue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55010968.5090606@windriver.com \
--to=ying.xue@windriver.com \
--cc=Paul.Gortmaker@windriver.com \
--cc=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=fengguang.wu@intel.com \
--cc=jon.maloy@ericsson.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.