From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW0WQ-00031k-43 for qemu-devel@nongnu.org; Thu, 12 Mar 2015 06:39:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YW0WM-00027e-Sv for qemu-devel@nongnu.org; Thu, 12 Mar 2015 06:39:22 -0400 Received: from [59.151.112.132] (port=31127 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW0WM-00027E-7m for qemu-devel@nongnu.org; Thu, 12 Mar 2015 06:39:18 -0400 Message-ID: <55016B3A.1080906@cn.fujitsu.com> Date: Thu, 12 Mar 2015 18:32:26 +0800 From: Chen Fan MIME-Version: 1.0 References: <6d56c70c7895d6c66db250bd03744b9bd7a092eb.1425951373.git.chen.fan.fnst@cn.fujitsu.com> <54FE9092.1020403@msgid.tls.msk.ru> <20150310155745-mutt-send-email-mst@redhat.com> In-Reply-To: <20150310155745-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/3] pcie_aer: fix typos in pcie_aer_inject_error comment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Michael Tokarev Cc: alex.williamson@redhat.com, qemu-devel@nongnu.org On 03/10/2015 10:57 PM, Michael S. Tsirkin wrote: > On Tue, Mar 10, 2015 at 09:34:58AM +0300, Michael Tokarev wrote: >> 10.03.2015 04:49, Chen Fan =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> Refer to "PCI Express Base Spec3.0", this comments can't >>> fit the description in spec, so we should fix them. >>> >>> Signed-off-by: Chen Fan >>> --- >>> hw/pci/pcie_aer.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c >>> index 1f4be16..7ca077a 100644 >>> --- a/hw/pci/pcie_aer.c >>> +++ b/hw/pci/pcie_aer.c >>> @@ -618,11 +618,11 @@ static bool pcie_aer_inject_uncor_error(PCIEAERIn= ject *inj, bool is_fatal) >>> * non-Function specific error must be recorded in all functions. >>> * It is the responsibility of the caller of this function. >>> * It is also caller's responsibility to determine which function sho= uld >>> - * report the rerror. >>> + * report the error. >>> * >>> * 6.2.4 Error Logging >>> - * 6.2.5 Sqeunce of Device Error Signaling and Logging Operations >>> - * table 6-2: Flowchard Showing Sequence of Device Error Signaling and= Logging >>> + * 6.2.5 Sequence of Device Error Signaling and Logging Operations >>> + * table 6-2: Flowchart Showing Sequence of Device Error Signaling and= Logging >>> * Operations >> this 6-2 is not a table, it is "Figure 6-2" on page 479, unless, ofcours= e, you mean >> "Table 6-2: General PCI Express Error List" on page 481. >> >> I can fix this when applying. >> >> Thanks, >> >> /mjt > OK so you want to take all 3 patches? Hi mjt, can you check in these patch? Thanks, Chen > > >>> */ >>> int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err) >>> > . >